From: Jeff King <peff@peff.net>
To: Jon Simons <jon@jonsimons.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] always check for NULL return from packet_read_line()
Date: Thu, 8 Feb 2018 13:58:42 -0500 [thread overview]
Message-ID: <20180208185842.GA1814@sigill.intra.peff.net> (raw)
In-Reply-To: <1518115670-2646-3-git-send-email-jon@jonsimons.org>
On Thu, Feb 08, 2018 at 01:47:50PM -0500, Jon Simons wrote:
> The packet_read_line() function will die if it sees any
> protocol or socket errors. But it will return NULL for a
> flush packet; some callers which are not expecting this may
> dereference NULL if they get an unexpected flush. This would
> involve the other side breaking protocol, but we should
> flag the error rather than segfault.
As one might guess from the dual authorship on this series, Jon and I
discussed these off list. So this one is
Reviewed-by: Jeff King <peff@peff.net>
And the other one, too, but I'm not sure that carries any weight. :)
-Peff
prev parent reply other threads:[~2018-02-08 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 18:47 [PATCH 0/2] Fix NULL checks for some packet_read_line call sites Jon Simons
2018-02-08 18:47 ` [PATCH 1/2] correct error messages for NULL packet_read_line() Jon Simons
2018-02-08 18:47 ` [PATCH 2/2] always check for NULL return from packet_read_line() Jon Simons
2018-02-08 18:58 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208185842.GA1814@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jon@jonsimons.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).