From: Brandon Williams <bmwill@google.com> To: git@vger.kernel.org Cc: sbeller@google.com, peff@peff.net, gitster@pobox.com, jrnieder@gmail.com, stolee@gmail.com, git@jeffhostetler.com, pclouds@gmail.com, Brandon Williams <bmwill@google.com> Subject: [PATCH v3 07/35] connect: convert get_remote_heads to use struct packet_reader Date: Tue, 6 Feb 2018 17:12:44 -0800 [thread overview] Message-ID: <20180207011312.189834-8-bmwill@google.com> (raw) In-Reply-To: <20180207011312.189834-1-bmwill@google.com> In order to allow for better control flow when protocol_v2 is introduced convert 'get_remote_heads()' to use 'struct packet_reader' to read packet lines. This enables a client to be able to peek the first line of a server's response (without consuming it) in order to determine the protocol version its speaking and then passing control to the appropriate handler. This is needed because the initial response from a server speaking protocol_v0 includes the first ref, while subsequent protocol versions respond with a version line. We want to be able to read this first line without consuming the first ref sent in the protocol_v0 case so that the protocol version the server is speaking can be determined outside of 'get_remote_heads()' in a future patch. Signed-off-by: Brandon Williams <bmwill@google.com> --- connect.c | 174 ++++++++++++++++++++++++++++++++++---------------------------- 1 file changed, 96 insertions(+), 78 deletions(-) diff --git a/connect.c b/connect.c index c3a014c5b..00e90075c 100644 --- a/connect.c +++ b/connect.c @@ -48,6 +48,12 @@ int check_ref_type(const struct ref *ref, int flags) static void die_initial_contact(int unexpected) { + /* + * A hang-up after seeing some response from the other end + * means that it is unexpected, as we know the other end is + * willing to talk to us. A hang-up before seeing any + * response does not necessarily mean an ACL problem, though. + */ if (unexpected) die(_("The remote end hung up upon initial contact")); else @@ -56,6 +62,41 @@ static void die_initial_contact(int unexpected) "and the repository exists.")); } +static enum protocol_version discover_version(struct packet_reader *reader) +{ + enum protocol_version version = protocol_unknown_version; + + /* + * Peek the first line of the server's response to + * determine the protocol version the server is speaking. + */ + switch (packet_reader_peek(reader)) { + case PACKET_READ_EOF: + die_initial_contact(0); + case PACKET_READ_FLUSH: + case PACKET_READ_DELIM: + version = protocol_v0; + break; + case PACKET_READ_NORMAL: + version = determine_protocol_version_client(reader->line); + break; + } + + /* Maybe process capabilities here, at least for v2 */ + switch (version) { + case protocol_v1: + /* Read the peeked version line */ + packet_reader_read(reader); + break; + case protocol_v0: + break; + case protocol_unknown_version: + die("unknown protocol version: '%s'\n", reader->line); + } + + return version; +} + static void parse_one_symref_info(struct string_list *symref, const char *val, int len) { char *sym, *target; @@ -109,60 +150,21 @@ static void annotate_refs_with_symref_info(struct ref *ref) string_list_clear(&symref, 0); } -/* - * Read one line of a server's ref advertisement into packet_buffer. - */ -static int read_remote_ref(int in, char **src_buf, size_t *src_len, - int *responded) +static void process_capabilities(const char *line, int *len) { - int len = packet_read(in, src_buf, src_len, - packet_buffer, sizeof(packet_buffer), - PACKET_READ_GENTLE_ON_EOF | - PACKET_READ_CHOMP_NEWLINE); - const char *arg; - if (len < 0) - die_initial_contact(*responded); - if (len > 4 && skip_prefix(packet_buffer, "ERR ", &arg)) - die("remote error: %s", arg); - - *responded = 1; - - return len; -} - -#define EXPECTING_PROTOCOL_VERSION 0 -#define EXPECTING_FIRST_REF 1 -#define EXPECTING_REF 2 -#define EXPECTING_SHALLOW 3 - -/* Returns 1 if packet_buffer is a protocol version pkt-line, 0 otherwise. */ -static int process_protocol_version(void) -{ - switch (determine_protocol_version_client(packet_buffer)) { - case protocol_v1: - return 1; - case protocol_v0: - return 0; - default: - die("server is speaking an unknown protocol"); - } -} - -static void process_capabilities(int *len) -{ - int nul_location = strlen(packet_buffer); + int nul_location = strlen(line); if (nul_location == *len) return; - server_capabilities = xstrdup(packet_buffer + nul_location + 1); + server_capabilities = xstrdup(line + nul_location + 1); *len = nul_location; } -static int process_dummy_ref(void) +static int process_dummy_ref(const char *line) { struct object_id oid; const char *name; - if (parse_oid_hex(packet_buffer, &oid, &name)) + if (parse_oid_hex(line, &oid, &name)) return 0; if (*name != ' ') return 0; @@ -171,20 +173,20 @@ static int process_dummy_ref(void) return !oidcmp(&null_oid, &oid) && !strcmp(name, "capabilities^{}"); } -static void check_no_capabilities(int len) +static void check_no_capabilities(const char *line, int len) { - if (strlen(packet_buffer) != len) + if (strlen(line) != len) warning("Ignoring capabilities after first line '%s'", - packet_buffer + strlen(packet_buffer)); + line + strlen(line)); } -static int process_ref(int len, struct ref ***list, unsigned int flags, - struct oid_array *extra_have) +static int process_ref(const char *line, int len, struct ref ***list, + unsigned int flags, struct oid_array *extra_have) { struct object_id old_oid; const char *name; - if (parse_oid_hex(packet_buffer, &old_oid, &name)) + if (parse_oid_hex(line, &old_oid, &name)) return 0; if (*name != ' ') return 0; @@ -200,16 +202,17 @@ static int process_ref(int len, struct ref ***list, unsigned int flags, **list = ref; *list = &ref->next; } - check_no_capabilities(len); + check_no_capabilities(line, len); return 1; } -static int process_shallow(int len, struct oid_array *shallow_points) +static int process_shallow(const char *line, int len, + struct oid_array *shallow_points) { const char *arg; struct object_id old_oid; - if (!skip_prefix(packet_buffer, "shallow ", &arg)) + if (!skip_prefix(line, "shallow ", &arg)) return 0; if (get_oid_hex(arg, &old_oid)) @@ -217,10 +220,17 @@ static int process_shallow(int len, struct oid_array *shallow_points) if (!shallow_points) die("repository on the other end cannot be shallow"); oid_array_append(shallow_points, &old_oid); - check_no_capabilities(len); + check_no_capabilities(line, len); return 1; } +enum get_remote_heads_state { + EXPECTING_FIRST_REF = 0, + EXPECTING_REF, + EXPECTING_SHALLOW, + EXPECTING_DONE, +}; + /* * Read all the refs from the other end */ @@ -230,47 +240,55 @@ struct ref **get_remote_heads(int in, char *src_buf, size_t src_len, struct oid_array *shallow_points) { struct ref **orig_list = list; + int len = 0; + enum get_remote_heads_state state = EXPECTING_FIRST_REF; + struct packet_reader reader; + const char *arg; - /* - * A hang-up after seeing some response from the other end - * means that it is unexpected, as we know the other end is - * willing to talk to us. A hang-up before seeing any - * response does not necessarily mean an ACL problem, though. - */ - int responded = 0; - int len; - int state = EXPECTING_PROTOCOL_VERSION; + packet_reader_init(&reader, in, src_buf, src_len, + PACKET_READ_CHOMP_NEWLINE | + PACKET_READ_GENTLE_ON_EOF); + + discover_version(&reader); *list = NULL; - while ((len = read_remote_ref(in, &src_buf, &src_len, &responded))) { + while (state != EXPECTING_DONE) { + switch (packet_reader_read(&reader)) { + case PACKET_READ_EOF: + die_initial_contact(1); + case PACKET_READ_NORMAL: + len = reader.pktlen; + if (len > 4 && skip_prefix(reader.line, "ERR ", &arg)) + die("remote error: %s", arg); + break; + case PACKET_READ_FLUSH: + state = EXPECTING_DONE; + break; + case PACKET_READ_DELIM: + die("invalid packet"); + } + switch (state) { - case EXPECTING_PROTOCOL_VERSION: - if (process_protocol_version()) { - state = EXPECTING_FIRST_REF; - break; - } - state = EXPECTING_FIRST_REF; - /* fallthrough */ case EXPECTING_FIRST_REF: - process_capabilities(&len); - if (process_dummy_ref()) { + process_capabilities(reader.line, &len); + if (process_dummy_ref(reader.line)) { state = EXPECTING_SHALLOW; break; } state = EXPECTING_REF; /* fallthrough */ case EXPECTING_REF: - if (process_ref(len, &list, flags, extra_have)) + if (process_ref(reader.line, len, &list, flags, extra_have)) break; state = EXPECTING_SHALLOW; /* fallthrough */ case EXPECTING_SHALLOW: - if (process_shallow(len, shallow_points)) + if (process_shallow(reader.line, len, shallow_points)) break; - die("protocol error: unexpected '%s'", packet_buffer); - default: - die("unexpected state %d", state); + die("protocol error: unexpected '%s'", reader.line); + case EXPECTING_DONE: + break; } } -- 2.16.0.rc1.238.g530d649a79-goog
next prev parent reply other threads:[~2018-02-07 1:15 UTC|newest] Thread overview: 362+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-03 0:18 [PATCH 00/26] protocol version 2 Brandon Williams 2018-01-03 0:18 ` [PATCH 01/26] pkt-line: introduce packet_read_with_status Brandon Williams 2018-01-03 19:27 ` Stefan Beller 2018-01-05 23:41 ` Brandon Williams 2018-01-09 18:04 ` Jonathan Tan 2018-01-09 19:28 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 02/26] pkt-line: introduce struct packet_reader Brandon Williams 2018-01-09 18:08 ` Jonathan Tan 2018-01-09 19:19 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 03/26] pkt-line: add delim packet support Brandon Williams 2018-01-03 0:18 ` [PATCH 04/26] upload-pack: convert to a builtin Brandon Williams 2018-01-03 20:33 ` Stefan Beller 2018-01-03 20:39 ` Brandon Williams 2018-02-21 21:47 ` Jonathan Nieder 2018-02-21 23:35 ` Junio C Hamano 2018-01-03 0:18 ` [PATCH 05/26] upload-pack: factor out processing lines Brandon Williams 2018-01-03 20:38 ` Stefan Beller 2018-01-03 0:18 ` [PATCH 06/26] transport: use get_refs_via_connect to get refs Brandon Williams 2018-01-03 21:20 ` Stefan Beller 2018-01-03 0:18 ` [PATCH 07/26] connect: convert get_remote_heads to use struct packet_reader Brandon Williams 2018-01-09 18:27 ` Jonathan Tan 2018-01-09 19:09 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 08/26] connect: discover protocol version outside of get_remote_heads Brandon Williams 2018-01-03 0:18 ` [PATCH 09/26] transport: store protocol version Brandon Williams 2018-01-09 18:41 ` Jonathan Tan 2018-01-09 19:15 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 10/26] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams 2018-01-03 0:18 ` [PATCH 11/26] serve: introduce git-serve Brandon Williams 2018-01-09 20:24 ` Jonathan Tan 2018-01-09 22:16 ` Brandon Williams 2018-01-09 22:28 ` Jonathan Tan 2018-01-09 22:34 ` Brandon Williams 2018-02-01 18:48 ` Jeff Hostetler 2018-02-01 18:57 ` Stefan Beller 2018-02-01 19:09 ` Jeff Hostetler 2018-02-01 20:05 ` Brandon Williams 2018-02-01 19:45 ` Randall S. Becker 2018-02-01 20:08 ` 'Brandon Williams' 2018-02-01 20:37 ` Randall S. Becker 2018-02-01 20:50 ` Stefan Beller 2018-01-03 0:18 ` [PATCH 12/26] ls-refs: introduce ls-refs server command Brandon Williams 2018-01-04 0:17 ` Stefan Beller 2018-01-05 23:49 ` Brandon Williams 2018-01-09 20:50 ` Jonathan Tan 2018-01-16 19:23 ` Brandon Williams 2018-02-01 19:16 ` Jeff Hostetler 2018-02-07 0:55 ` Brandon Williams 2018-01-03 0:18 ` [PATCH 13/26] connect: request remote refs using v2 Brandon Williams 2018-01-09 22:24 ` Jonathan Tan 2018-01-03 0:18 ` [PATCH 14/26] transport: convert get_refs_list to take a list of ref patterns Brandon Williams 2018-01-03 0:18 ` [PATCH 15/26] transport: convert transport_get_remote_refs " Brandon Williams 2018-01-03 0:18 ` [PATCH 16/26] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams 2018-01-03 0:18 ` [PATCH 17/26] fetch: pass ref patterns when fetching Brandon Williams 2018-01-03 0:18 ` [PATCH 18/26] push: pass ref patterns when pushing Brandon Williams 2018-01-03 0:18 ` [PATCH 19/26] upload-pack: introduce fetch server command Brandon Williams 2018-01-04 1:07 ` Stefan Beller 2018-01-03 0:18 ` [PATCH 20/26] fetch-pack: perform a fetch using v2 Brandon Williams 2018-01-04 1:23 ` Stefan Beller 2018-01-05 23:55 ` Brandon Williams 2018-01-10 0:05 ` Jonathan Tan 2018-01-03 0:18 ` [PATCH 21/26] transport-helper: remove name parameter Brandon Williams 2018-01-03 0:18 ` [PATCH 22/26] transport-helper: refactor process_connect_service Brandon Williams 2018-01-03 0:18 ` [PATCH 23/26] transport-helper: introduce connect-half-duplex Brandon Williams 2018-01-03 0:18 ` [PATCH 24/26] pkt-line: add packet_buf_write_len function Brandon Williams 2018-01-03 0:18 ` [PATCH 25/26] remote-curl: create copy of the service name Brandon Williams 2018-01-03 0:18 ` [PATCH 26/26] remote-curl: implement connect-half-duplex command Brandon Williams 2018-01-10 0:10 ` Jonathan Tan 2018-01-10 17:57 ` Jonathan Tan 2018-01-11 1:09 ` Brandon Williams 2018-01-09 17:55 ` [PATCH 00/26] protocol version 2 Jonathan Tan 2018-01-11 0:23 ` Brandon Williams 2018-01-25 23:58 ` [PATCH v2 00/27] " Brandon Williams 2018-01-25 23:58 ` [PATCH v2 01/27] pkt-line: introduce packet_read_with_status Brandon Williams 2018-01-25 23:58 ` [PATCH v2 02/27] pkt-line: introduce struct packet_reader Brandon Williams 2018-01-25 23:58 ` [PATCH v2 03/27] pkt-line: add delim packet support Brandon Williams 2018-01-25 23:58 ` [PATCH v2 04/27] upload-pack: convert to a builtin Brandon Williams 2018-01-25 23:58 ` [PATCH v2 05/27] upload-pack: factor out processing lines Brandon Williams 2018-01-26 20:12 ` Stefan Beller 2018-01-26 21:33 ` Brandon Williams 2018-01-31 14:08 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 06/27] transport: use get_refs_via_connect to get refs Brandon Williams 2018-01-25 23:58 ` [PATCH v2 07/27] connect: convert get_remote_heads to use struct packet_reader Brandon Williams 2018-01-25 23:58 ` [PATCH v2 08/27] connect: discover protocol version outside of get_remote_heads Brandon Williams 2018-01-31 14:40 ` Derrick Stolee 2018-02-01 17:57 ` Brandon Williams 2018-01-25 23:58 ` [PATCH v2 09/27] transport: store protocol version Brandon Williams 2018-01-31 14:45 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 10/27] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams 2018-01-31 14:54 ` Derrick Stolee 2018-02-02 22:44 ` Brandon Williams 2018-02-05 14:14 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 11/27] test-pkt-line: introduce a packet-line test helper Brandon Williams 2018-01-25 23:58 ` [PATCH v2 12/27] serve: introduce git-serve Brandon Williams 2018-01-26 10:39 ` Duy Nguyen 2018-02-27 5:46 ` Jonathan Nieder 2018-01-31 15:39 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 13/27] ls-refs: introduce ls-refs server command Brandon Williams 2018-01-26 22:20 ` Stefan Beller 2018-02-02 22:31 ` Brandon Williams 2018-01-25 23:58 ` [PATCH v2 14/27] connect: request remote refs using v2 Brandon Williams 2018-01-31 15:22 ` Derrick Stolee 2018-01-31 20:10 ` Eric Sunshine 2018-01-31 22:14 ` Derrick Stolee 2018-01-25 23:58 ` [PATCH v2 15/27] transport: convert get_refs_list to take a list of ref patterns Brandon Williams 2018-01-25 23:58 ` [PATCH v2 16/27] transport: convert transport_get_remote_refs " Brandon Williams 2018-01-25 23:58 ` [PATCH v2 17/27] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams 2018-01-25 23:58 ` [PATCH v2 18/27] fetch: pass ref patterns when fetching Brandon Williams 2018-01-25 23:58 ` [PATCH v2 19/27] push: pass ref patterns when pushing Brandon Williams 2018-01-25 23:58 ` [PATCH v2 20/27] upload-pack: introduce fetch server command Brandon Williams 2018-01-25 23:58 ` [PATCH v2 21/27] fetch-pack: perform a fetch using v2 Brandon Williams 2018-01-25 23:58 ` [PATCH v2 22/27] transport-helper: remove name parameter Brandon Williams 2018-01-25 23:58 ` [PATCH v2 23/27] transport-helper: refactor process_connect_service Brandon Williams 2018-01-25 23:58 ` [PATCH v2 24/27] transport-helper: introduce stateless-connect Brandon Williams 2018-01-25 23:58 ` [PATCH v2 25/27] pkt-line: add packet_buf_write_len function Brandon Williams 2018-01-25 23:58 ` [PATCH v2 26/27] remote-curl: create copy of the service name Brandon Williams 2018-01-25 23:58 ` [PATCH v2 27/27] remote-curl: implement stateless-connect command Brandon Williams 2018-01-31 16:00 ` [PATCH v2 00/27] protocol version 2 Derrick Stolee 2018-02-07 0:58 ` Brandon Williams 2018-02-01 19:40 ` Jeff Hostetler 2018-02-07 1:12 ` [PATCH v3 00/35] " Brandon Williams 2018-02-07 1:12 ` [PATCH v3 01/35] pkt-line: introduce packet_read_with_status Brandon Williams 2018-02-13 0:25 ` Jonathan Nieder 2018-02-07 1:12 ` [PATCH v3 02/35] pkt-line: introduce struct packet_reader Brandon Williams 2018-02-13 0:49 ` Jonathan Nieder 2018-02-27 18:14 ` Brandon Williams 2018-02-27 19:20 ` Jonathan Nieder 2018-02-27 5:57 ` Jonathan Nieder 2018-02-27 6:12 ` Jonathan Nieder 2018-02-07 1:12 ` [PATCH v3 03/35] pkt-line: add delim packet support Brandon Williams 2018-02-22 19:13 ` Stefan Beller 2018-02-22 19:37 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 04/35] upload-pack: convert to a builtin Brandon Williams 2018-02-21 21:44 ` Jonathan Tan 2018-02-22 9:58 ` Jeff King 2018-02-22 18:07 ` Brandon Williams 2018-02-22 18:14 ` Jeff King 2018-02-22 19:38 ` Jonathan Nieder 2018-02-22 20:19 ` Jeff King 2018-02-22 20:21 ` Jeff King 2018-02-22 21:26 ` Jonathan Nieder 2018-02-22 21:44 ` Jeff King 2018-03-12 22:43 ` Jonathan Nieder 2018-03-12 23:28 ` Jeff King 2018-03-12 23:37 ` Jonathan Nieder 2018-03-12 23:52 ` Jeff King 2018-02-23 21:09 ` Brandon Williams 2018-03-03 4:24 ` Jeff King 2018-02-22 21:24 ` Jonathan Nieder 2018-02-22 21:44 ` Jeff King 2018-02-22 22:21 ` Jeff King 2018-02-22 22:42 ` Jonathan Nieder 2018-02-22 23:05 ` Jeff King 2018-02-22 23:23 ` Jeff King 2018-02-07 1:12 ` [PATCH v3 05/35] upload-pack: factor out processing lines Brandon Williams 2018-02-22 19:31 ` Stefan Beller 2018-02-22 19:39 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 06/35] transport: use get_refs_via_connect to get refs Brandon Williams 2018-02-27 6:08 ` Jonathan Nieder 2018-02-27 18:17 ` Brandon Williams 2018-02-27 19:25 ` Jonathan Nieder 2018-02-27 19:46 ` Brandon Williams 2018-02-07 1:12 ` Brandon Williams [this message] 2018-02-22 19:52 ` [PATCH v3 07/35] connect: convert get_remote_heads to use struct packet_reader Stefan Beller 2018-02-22 20:09 ` Stefan Beller 2018-02-23 21:30 ` Brandon Williams 2018-02-23 21:48 ` Stefan Beller 2018-02-23 22:56 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 08/35] connect: discover protocol version outside of get_remote_heads Brandon Williams 2018-02-21 22:11 ` Jonathan Tan 2018-02-22 18:17 ` Brandon Williams 2018-02-22 19:22 ` Jonathan Tan 2018-02-07 1:12 ` [PATCH v3 09/35] transport: store protocol version Brandon Williams 2018-02-07 1:12 ` [PATCH v3 10/35] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams 2018-02-27 6:18 ` Jonathan Nieder 2018-02-27 18:41 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 11/35] test-pkt-line: introduce a packet-line test helper Brandon Williams 2018-02-22 20:40 ` Stefan Beller 2018-02-23 21:22 ` Brandon Williams 2018-03-03 4:25 ` Jeff King 2018-03-05 18:48 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 12/35] serve: introduce git-serve Brandon Williams 2018-02-21 22:45 ` Jonathan Tan 2018-02-23 21:33 ` Brandon Williams 2018-02-27 18:05 ` Jonathan Tan 2018-02-27 18:34 ` Brandon Williams 2018-02-22 9:33 ` Jeff King 2018-02-23 21:45 ` Brandon Williams 2018-03-03 4:33 ` Jeff King 2018-03-05 18:43 ` Brandon Williams 2018-03-05 20:52 ` Jeff King 2018-03-05 21:36 ` Jonathan Nieder 2018-03-06 6:29 ` Jeff King 2018-03-12 23:46 ` Jeff King 2018-02-07 1:12 ` [PATCH v3 13/35] ls-refs: introduce ls-refs server command Brandon Williams 2018-02-22 9:48 ` Jeff King 2018-02-23 0:45 ` Brandon Williams 2018-02-24 0:19 ` Brandon Williams 2018-02-24 4:03 ` Jeff King 2018-02-24 4:01 ` Jeff King 2018-02-26 22:33 ` Junio C Hamano 2018-02-27 0:02 ` Ævar Arnfjörð Bjarmason 2018-02-27 5:15 ` Jonathan Nieder 2018-02-27 18:02 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 14/35] connect: request remote refs using v2 Brandon Williams 2018-02-21 22:54 ` Jonathan Tan 2018-02-22 18:19 ` Brandon Williams 2018-02-22 18:26 ` Jeff King 2018-02-22 19:25 ` Jonathan Tan 2018-02-27 6:21 ` Jonathan Nieder 2018-02-27 21:58 ` Junio C Hamano 2018-02-27 22:04 ` Jeff King 2018-02-27 22:10 ` Eric Sunshine 2018-02-27 22:18 ` Jeff King 2018-02-27 23:32 ` Junio C Hamano 2018-02-27 6:51 ` Jonathan Nieder 2018-02-27 19:30 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 15/35] transport: convert get_refs_list to take a list of ref patterns Brandon Williams 2018-02-21 22:56 ` Jonathan Tan 2018-02-22 18:25 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 16/35] transport: convert transport_get_remote_refs " Brandon Williams 2018-02-21 22:58 ` Jonathan Tan 2018-02-22 18:26 ` Brandon Williams 2018-02-22 19:32 ` Jonathan Tan 2018-02-22 19:51 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 17/35] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams 2018-02-07 1:12 ` [PATCH v3 18/35] fetch: pass ref patterns when fetching Brandon Williams 2018-02-27 6:53 ` Jonathan Nieder 2018-02-07 1:12 ` [PATCH v3 19/35] push: pass ref patterns when pushing Brandon Williams 2018-02-27 18:23 ` Stefan Beller 2018-02-07 1:12 ` [PATCH v3 20/35] upload-pack: introduce fetch server command Brandon Williams 2018-02-21 23:46 ` Jonathan Tan 2018-02-22 18:48 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 21/35] fetch-pack: perform a fetch using v2 Brandon Williams 2018-02-24 0:54 ` Jonathan Tan 2018-02-26 22:23 ` Brandon Williams 2018-02-27 19:27 ` Stefan Beller 2018-02-27 19:40 ` Brandon Williams 2018-02-07 1:12 ` [PATCH v3 22/35] upload-pack: support shallow requests Brandon Williams 2018-02-07 19:00 ` Stefan Beller 2018-02-10 10:23 ` Duy Nguyen 2018-02-13 17:06 ` Brandon Williams 2018-02-27 18:29 ` Jonathan Nieder 2018-02-27 18:57 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 23/35] fetch-pack: " Brandon Williams 2018-02-23 19:37 ` Jonathan Tan 2018-02-23 19:56 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 24/35] connect: refactor git_connect to only get the protocol version once Brandon Williams 2018-02-21 23:51 ` Jonathan Tan 2018-02-07 1:13 ` [PATCH v3 25/35] connect: don't request v2 when pushing Brandon Williams 2018-02-07 1:13 ` [PATCH v3 26/35] transport-helper: remove name parameter Brandon Williams 2018-02-27 23:03 ` Jonathan Nieder 2018-02-07 1:13 ` [PATCH v3 27/35] transport-helper: refactor process_connect_service Brandon Williams 2018-02-07 1:13 ` [PATCH v3 28/35] transport-helper: introduce stateless-connect Brandon Williams 2018-02-22 0:01 ` Jonathan Tan 2018-02-22 18:53 ` Brandon Williams 2018-02-22 21:55 ` Jonathan Tan 2018-02-27 23:30 ` Jonathan Nieder 2018-02-28 19:09 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 29/35] pkt-line: add packet_buf_write_len function Brandon Williams 2018-02-27 23:11 ` Jonathan Nieder 2018-02-28 1:08 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 30/35] remote-curl: create copy of the service name Brandon Williams 2018-02-22 0:06 ` Jonathan Tan 2018-02-22 18:56 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 31/35] remote-curl: store the protocol version the server responded with Brandon Williams 2018-02-27 23:17 ` Jonathan Nieder 2018-02-07 1:13 ` [PATCH v3 32/35] http: allow providing extra headers for http requests Brandon Williams 2018-02-22 0:09 ` Jonathan Tan 2018-02-22 18:58 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 33/35] http: don't always add Git-Protocol header Brandon Williams 2018-02-07 1:13 ` [PATCH v3 34/35] remote-curl: implement stateless-connect command Brandon Williams 2018-02-28 0:05 ` Jonathan Nieder 2018-02-28 20:21 ` Brandon Williams 2018-02-07 1:13 ` [PATCH v3 35/35] remote-curl: don't request v2 when pushing Brandon Williams 2018-02-22 0:12 ` Jonathan Tan 2018-02-22 18:59 ` Brandon Williams 2018-02-22 19:09 ` Brandon Williams 2018-02-12 14:50 ` [PATCH v3 00/35] protocol version 2 Derrick Stolee 2018-02-21 20:01 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 " Brandon Williams 2018-02-28 23:22 ` [PATCH v4 01/35] pkt-line: introduce packet_read_with_status Brandon Williams 2018-03-13 19:35 ` Jonathan Tan 2018-03-13 19:52 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 02/35] pkt-line: allow peeking a packet line without consuming it Brandon Williams 2018-03-01 20:48 ` Junio C Hamano 2018-03-12 21:56 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 03/35] pkt-line: add delim packet support Brandon Williams 2018-03-01 20:50 ` Junio C Hamano 2018-03-01 21:04 ` Junio C Hamano 2018-03-01 22:49 ` Brandon Williams 2018-03-01 23:43 ` Junio C Hamano 2018-02-28 23:22 ` [PATCH v4 04/35] upload-pack: convert to a builtin Brandon Williams 2018-03-13 16:40 ` Jonathan Tan 2018-03-13 19:50 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 05/35] upload-pack: factor out processing lines Brandon Williams 2018-03-01 21:25 ` Junio C Hamano 2018-03-12 22:24 ` Brandon Williams 2018-03-12 22:39 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 06/35] transport: use get_refs_via_connect to get refs Brandon Williams 2018-03-01 21:25 ` Junio C Hamano 2018-02-28 23:22 ` [PATCH v4 07/35] connect: convert get_remote_heads to use struct packet_reader Brandon Williams 2018-02-28 23:22 ` [PATCH v4 08/35] connect: discover protocol version outside of get_remote_heads Brandon Williams 2018-03-13 15:49 ` Jonathan Tan 2018-02-28 23:22 ` [PATCH v4 09/35] transport: store protocol version Brandon Williams 2018-02-28 23:22 ` [PATCH v4 10/35] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams 2018-02-28 23:22 ` [PATCH v4 11/35] test-pkt-line: introduce a packet-line test helper Brandon Williams 2018-02-28 23:22 ` [PATCH v4 12/35] serve: introduce git-serve Brandon Williams 2018-03-01 23:11 ` Junio C Hamano 2018-03-12 22:08 ` Brandon Williams 2018-03-02 20:42 ` Junio C Hamano 2018-03-13 21:40 ` Brandon Williams 2018-03-02 20:56 ` Junio C Hamano 2018-03-13 21:35 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 13/35] ls-refs: introduce ls-refs server command Brandon Williams 2018-03-02 21:13 ` Junio C Hamano 2018-03-13 21:27 ` Brandon Williams 2018-03-03 4:43 ` Jeff King 2018-03-05 18:21 ` Brandon Williams 2018-03-05 18:29 ` Jonathan Nieder 2018-03-05 20:38 ` Jeff King 2018-03-05 20:28 ` Jeff King 2018-03-13 21:23 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 14/35] connect: request remote refs using v2 Brandon Williams 2018-02-28 23:22 ` [PATCH v4 15/35] transport: convert get_refs_list to take a list of ref patterns Brandon Williams 2018-02-28 23:22 ` [PATCH v4 16/35] transport: convert transport_get_remote_refs " Brandon Williams 2018-03-13 16:00 ` Jonathan Tan 2018-02-28 23:22 ` [PATCH v4 17/35] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams 2018-03-02 22:13 ` Junio C Hamano 2018-02-28 23:22 ` [PATCH v4 18/35] fetch: pass ref patterns when fetching Brandon Williams 2018-03-02 22:20 ` Junio C Hamano 2018-03-12 22:18 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 19/35] push: pass ref patterns when pushing Brandon Williams 2018-03-02 22:25 ` Junio C Hamano 2018-03-12 22:20 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 20/35] upload-pack: introduce fetch server command Brandon Williams 2018-03-13 16:20 ` Jonathan Tan 2018-03-13 21:49 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 21/35] fetch-pack: perform a fetch using v2 Brandon Williams 2018-02-28 23:22 ` [PATCH v4 22/35] fetch-pack: support shallow requests Brandon Williams 2018-02-28 23:22 ` [PATCH v4 23/35] connect: refactor git_connect to only get the protocol version once Brandon Williams 2018-02-28 23:22 ` [PATCH v4 24/35] connect: don't request v2 when pushing Brandon Williams 2018-02-28 23:22 ` [PATCH v4 25/35] transport-helper: remove name parameter Brandon Williams 2018-02-28 23:22 ` [PATCH v4 26/35] transport-helper: refactor process_connect_service Brandon Williams 2018-02-28 23:22 ` [PATCH v4 27/35] transport-helper: introduce stateless-connect Brandon Williams 2018-03-13 16:30 ` Jonathan Tan 2018-03-14 17:36 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 28/35] pkt-line: add packet_buf_write_len function Brandon Williams 2018-02-28 23:22 ` [PATCH v4 29/35] remote-curl: create copy of the service name Brandon Williams 2018-03-13 16:32 ` Jonathan Tan 2018-02-28 23:22 ` [PATCH v4 30/35] remote-curl: store the protocol version the server responded with Brandon Williams 2018-02-28 23:22 ` [PATCH v4 31/35] http: allow providing extra headers for http requests Brandon Williams 2018-03-13 16:33 ` Jonathan Tan 2018-02-28 23:22 ` [PATCH v4 32/35] http: don't always add Git-Protocol header Brandon Williams 2018-02-28 23:22 ` [PATCH v4 33/35] http: eliminate "# service" line when using protocol v2 Brandon Williams 2018-02-28 23:22 ` [PATCH v4 34/35] remote-curl: implement stateless-connect command Brandon Williams 2018-03-02 20:07 ` Johannes Schindelin 2018-03-05 19:35 ` Brandon Williams 2018-02-28 23:22 ` [PATCH v4 35/35] remote-curl: don't request v2 when pushing Brandon Williams 2018-03-13 16:35 ` Jonathan Tan 2018-03-01 18:41 ` [PATCH v4 00/35] protocol version 2 Junio C Hamano 2018-03-01 19:16 ` Brandon Williams 2018-03-01 20:59 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180207011312.189834-8-bmwill@google.com \ --to=bmwill@google.com \ --cc=git@jeffhostetler.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=jrnieder@gmail.com \ --cc=pclouds@gmail.com \ --cc=peff@peff.net \ --cc=sbeller@google.com \ --cc=stolee@gmail.com \ --subject='Re: [PATCH v3 07/35] connect: convert get_remote_heads to use struct packet_reader' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).