From: Eric Wong <e@80x24.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Michal Suchánek" <msuchanek@suse.de>, git@vger.kernel.org
Subject: Re: git send-email sets date
Date: Mon, 29 Jan 2018 12:48:35 +0000 [thread overview]
Message-ID: <20180129124835.ngeywe7qstmzx555@untitled> (raw)
In-Reply-To: <CACBZZX7W4n9Q-uL0t1W1dttAxA=hU69fL9Tqsfe0wj5XP=O44w@mail.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> On Fri, Jan 26, 2018 at 6:32 PM, Michal Suchánek <msuchanek@suse.de> wrote:
> > This is wrong because the message will most likely not get delivered
> > when the author date differs from current time.
Even by a few seconds? I guess it depends on how many patches
you're sending at once. It uses number of patches to set Date:
header:
$time = time - scalar $#files;
(and does $time++ for each patch)
> Others have covered other bases here, but I just wanted to ask about
> this. Are there really mail setups that refuse to deliver or accept
> messages whose Date headers don't match what the expect? I would think
> that such issues wouldn't be present in the wild since SMTP daemons
> need to deal with messages that are e.g. held locally somewhere, or
> the only make it to your server days afterwards due to your own
> downtime + client retries.
Having a Date that's far off is one of many indicators used to
determine spam. SpamAssassin has a rules and scores which do
this, but it looks like the smallest one is for 3 and 6 hours
in the past (DATE_IN_PAST_03_06) so one would need 10800 patches
to trigger it (!?)
I definitely had problems back in the day with author date
being used as the Date: header, see:
commit 1d6a003a42b3c23ad7883b0bbe6a034728e51836
("git-send-email: do not pass custom Date: header")
next prev parent reply other threads:[~2018-01-29 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 17:32 git send-email sets date Michal Suchánek
2018-01-28 15:15 ` brian m. carlson
2018-01-28 15:56 ` Philip Oakley
2018-01-28 22:12 ` Theodore Ts'o
2018-01-30 20:41 ` Junio C Hamano
2018-01-28 22:32 ` Ævar Arnfjörð Bjarmason
2018-01-29 12:48 ` Eric Wong [this message]
2018-01-30 20:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129124835.ngeywe7qstmzx555@untitled \
--to=e@80x24.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).