From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] diff: add --compact-summary option to complement --stat
Date: Fri, 19 Jan 2018 16:53:44 -0500 [thread overview]
Message-ID: <20180119215344.GD12074@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq607xpmty.fsf@gitster.mtv.corp.google.com>
On Fri, Jan 19, 2018 at 01:20:41PM -0800, Junio C Hamano wrote:
> > Documentation/merge-config.txt | 4 ++
> > builtin/merge.c | 2 +
> > A+x t/t5573-pull-verify-signatures.sh | 81 ++++++++++++++++++++++++
> > t/t7612-merge-verify-signatures.sh | 45 +++++++++++++
> > 4 files changed, 132 insertions(+)
>
> I like the concept but given that additions and mode changes are
> rare events, I am not so sure if it is worth always wasting three
> columns like the above. Assuming that this is solely meant for
> human consumption and machine parsability is of no concern, I
> actually prefer the output format you said you've been using your
> personal fork, e.g.
>
> Documentation/merge-config.txt | 4 ++
> builtin/merge.c | 2 +
> t/t5573-pull-verify-signatures.sh (new, +x) | 81 ++++++++++++++++++++++++
> t/t7612-merge-verify-signatures.sh | 45 +++++++++++++
>
> That is
>
> (1) do not change the starting column at the leftmost end, and
> (2) do not permanently allocate the columns for "compact" summary.
I think the patch already does (2). In fact, it computes the max
compact-status size (so if you only have "A" and not "A+x", it wastes
only the one column).
I agree that (1) would save space in some cases, though IMHO it's a
little hard to notice.
-Peff
prev parent reply other threads:[~2018-01-19 21:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 13:22 [PATCH/RFC] diff: add --compact-summary option to complement --stat Nguyễn Thái Ngọc Duy
2018-01-13 18:37 ` Philip Oakley
2018-01-14 9:37 ` Simon Ruderich
2018-01-14 10:24 ` Duy Nguyen
2018-01-18 10:05 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2018-01-18 18:57 ` Eric Sunshine
2018-01-19 0:01 ` Duy Nguyen
2018-01-18 21:23 ` Ævar Arnfjörð Bjarmason
2018-01-19 0:06 ` Duy Nguyen
2018-01-18 22:48 ` Jeff King
2018-01-19 0:26 ` Duy Nguyen
2018-01-19 21:52 ` Jeff King
2018-01-19 21:20 ` Junio C Hamano
2018-01-19 21:53 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119215344.GD12074@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).