git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Gargi Sharma <gs051095@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, olyatelezhnaya@gmail.com
Subject: Re: [PATCH] mru: Replace mru.[ch] with list.h implementation
Date: Fri, 19 Jan 2018 16:46:55 -0500	[thread overview]
Message-ID: <20180119214655.GB12074@sigill.intra.peff.net> (raw)
In-Reply-To: <1516067185-1087-1-git-send-email-gs051095@gmail.com>

On Mon, Jan 15, 2018 at 08:46:25PM -0500, Gargi Sharma wrote:

> Replace the custom calls to mru.[ch] with calls to list.h. This patch is the
> final step in removing the mru API completely and inlining the logic.
> 
> Another discussion, here
> (https://public-inbox.org/git/CAOCi2DGYQr4jFf5ObY2buyhNJeaAPQKF8tbojn2W0b18Eo+Wgw@mail.gmail.com/)
> was on what has to be done with the next pointer of packed git type
> inside the
> packed_git structure. It can be removed _given_ that no one needs to
> access the list in order and can be sent as another patch.

Thanks for picking this up again. I agree that this is probably a good
stopping point for now, as I think just combining this with the 'next'
pointer may carry more side effects.

Aside from the braces thing that Christian mentioned (and the missing
signoff), this all looks good to me.

-Peff

  parent reply	other threads:[~2018-01-19 21:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16  1:46 [PATCH] mru: Replace mru.[ch] with list.h implementation Gargi Sharma
2018-01-19 18:26 ` Christian Couder
2018-01-19 21:01   ` Junio C Hamano
2018-01-19 21:46 ` Jeff King [this message]
2018-01-19 23:39   ` Gargi Sharma
  -- strict thread matches above, loose matches on Subject: below --
2017-11-11 18:06 Gargi Sharma
2017-11-12  9:54 ` Jeff King
2017-11-12  9:59   ` Jeff King
2017-11-12 12:49   ` Gargi Sharma
2017-11-12 16:16     ` Jeff King
2017-12-12 14:07       ` Оля Тележная

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180119214655.GB12074@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=gs051095@gmail.com \
    --cc=olyatelezhnaya@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).