From: Jeff King <peff@peff.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] diff: add --compact-summary option to complement --stat
Date: Thu, 18 Jan 2018 17:48:14 -0500 [thread overview]
Message-ID: <20180118224814.GA8473@sigill.intra.peff.net> (raw)
In-Reply-To: <20180118100546.32251-1-pclouds@gmail.com>
On Thu, Jan 18, 2018 at 05:05:46PM +0700, Nguyễn Thái Ngọc Duy wrote:
> This is partly inspired by gerrit web interface which shows diffstat
> like this, e.g. with commit 0433d533f1 (notice the "A" column on the
> third line):
>
> Documentation/merge-config.txt | 4 +
> builtin/merge.c | 2 +
> A t/t5573-pull-verify-signatures.sh | 81 ++++++++++++++++++
> t/t7612-merge-verify-signatures.sh | 45 ++++++++++
> 4 files changed, 132 insertions(+)
I like the general concept. Perusing "git log" output, though, it felt
like the summary column was very close to the filenames. What do you
think of putting it after the "|", where it is only close to a number?
Something like the patch below (on top of yours, but it probably needs
tweaked further for graph_width), which gives:
t/t5573-pull-verify-signatures.sh | A+x 78 ++++++++++++++++++++++++++++
(I know this is a bikeshed, so I'm perfectly willing to take "yuck, I
don't like that as well" as a response).
> The new option --compact-summary implements this with a tweak to support
> mode change, which is shown in --summary too.
One thing I noticed is that --compact-summary by itself does nothing.
Should it imply --stat?
-Peff
next prev parent reply other threads:[~2018-01-18 22:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 13:22 [PATCH/RFC] diff: add --compact-summary option to complement --stat Nguyễn Thái Ngọc Duy
2018-01-13 18:37 ` Philip Oakley
2018-01-14 9:37 ` Simon Ruderich
2018-01-14 10:24 ` Duy Nguyen
2018-01-18 10:05 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2018-01-18 18:57 ` Eric Sunshine
2018-01-19 0:01 ` Duy Nguyen
2018-01-18 21:23 ` Ævar Arnfjörð Bjarmason
2018-01-19 0:06 ` Duy Nguyen
2018-01-18 22:48 ` Jeff King [this message]
2018-01-19 0:26 ` Duy Nguyen
2018-01-19 21:52 ` Jeff King
2018-01-19 21:20 ` Junio C Hamano
2018-01-19 21:53 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118224814.GA8473@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).