From: Jeff King <peff@peff.net>
To: Derrick Stolee <dstolee@microsoft.com>
Cc: git@vger.kernel.org, git@jeffhostetler.com, stolee@gmail.com
Subject: Re: [PATCH] packfile: use get_be64() for large offsets
Date: Wed, 17 Jan 2018 17:29:53 -0500 [thread overview]
Message-ID: <20180117222953.GB16031@sigill.intra.peff.net> (raw)
In-Reply-To: <20180117190823.209469-1-dstolee@microsoft.com>
On Wed, Jan 17, 2018 at 02:08:23PM -0500, Derrick Stolee wrote:
> The pack-index version 2 format uses two 4-byte integers in network-byte order to represent one 8-byte value. The current implementation has several code clones for stitching these integers together.
Yeah, this seems like a no-brainer, and the patch itself looks obviously
correct.
Please wrap your commit messages a bit shorter, though (say, between
60-72 chars).
-Peff
next prev parent reply other threads:[~2018-01-17 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 19:08 [PATCH] packfile: use get_be64() for large offsets Derrick Stolee
2018-01-17 22:29 ` Jeff King [this message]
2018-01-18 11:04 ` [PATCH v2] " Derrick Stolee
2018-01-18 14:15 ` SZEDER Gábor
2018-01-19 19:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117222953.GB16031@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dstolee@microsoft.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).