From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: 'Johannes Sixt' <j6t@kdbg.org>,
git@vger.kernel.org, 'Joachim Schmitz' <jojo@schmitz-digital.de>
Subject: Re: [BUG] test_must_fail: does not correctly detect failures - Was Git 2.16.0-rc2 Test Summary on NonStop
Date: Tue, 16 Jan 2018 03:00:51 +0000 [thread overview]
Message-ID: <20180116030051.GA244260@genre.crustytoothpaste.net> (raw)
In-Reply-To: <001b01d38e0c$ba16e250$2e44a6f0$@nexbridge.com>
[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]
On Mon, Jan 15, 2018 at 09:25:37AM -0500, Randall S. Becker wrote:
> On January 15, 2018 2:06 AM, Johannes Sixt wrote:
> > I take "die exits with non-zero" as a piece of information for the
> > *users* so that they can write "if perl foo.pl; then something; fi" in shell
> > scripts. I do *not* interpret it as leeway for implementers of perl to choose
> > any random value as exit code. Choosing 162 just to be funky would be
> > short-sighted. [I'm saying all this without knowing how perl specifies 'die'
> > beyond the paragraph you cited. Perhaps there's more about 'die' that
> > justifies exit code 162.] I'd say that the perl port is broken.
>
> I agree that 162 is wrong. Its interpretation is 128+signal, which
> clearly does not happen in this case. On the platform, if the perl
> script is via stdin, 162 or 169 are returned. If via file (perl
> file.pl), 255 comes back. The port has issues. I have an opened a bug
> report with the platform developers. Usual non-Open Source timeframes
> to fix apply. ☹
I believe the standard behavior for Perl with die is the following:
exit $! if $!;
exit $? >> 8 if $? >> 8;
exit 255; # otherwise
Is there an errno value on your port that matches 162? Maybe EBADF?
On Linux, I get the following:
genre ok % printf die | perl -; echo $?
Died at - line 1.
9
--
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]
next prev parent reply other threads:[~2018-01-16 3:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 20:16 [BUG] test_must_fail: does not correctly detect failures - Was Git 2.16.0-rc2 Test Summary on NonStop Randall S. Becker
2018-01-14 16:50 ` Randall S. Becker
2018-01-14 18:40 ` Johannes Sixt
2018-01-14 21:32 ` Randall S. Becker
2018-01-15 2:37 ` Randall S. Becker
2018-01-15 7:05 ` Johannes Sixt
2018-01-15 14:25 ` Randall S. Becker
2018-01-16 3:00 ` brian m. carlson [this message]
2018-01-16 3:31 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116030051.GA244260@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jojo@schmitz-digital.de \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).