From: Thomas Gummerer <t.gummerer@gmail.com>
To: randall.s.becker@rogers.com
Cc: git@vger.kernel.org, "Randall S. Becker" <rsbecker@nexbridge.com>
Subject: Re: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings
Date: Mon, 15 Jan 2018 20:43:01 +0000 [thread overview]
Message-ID: <20180115204301.GL2641@hank> (raw)
In-Reply-To: <20180114180748.14584-1-randall.s.becker@rogers.com>
Thanks for your patch! A few nitpicks below:
> Subject: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings
From Documentation/SubmittingPatches:
Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behavior.
I liked the subject Philip suggested in the other thread: "hashmap.h:
remove unnecessary void*", or maybe "hashmap.h: remove unnecessary
variable".
On 01/14, randall.s.becker@rogers.com wrote:
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> * hashmap.h: Revised the while loop in the hashmap_enable_item_counting
> to remove unneeded void* item.
As above, this should be described in an imperative mood, and describe
why this is a good change and should be merged. Maybe something along
the lines of the below?
In 'hashmap_enable_item_counting()', item is assigned but never
used. This causes a warning on HP NonStop. As the variable is
never used, fix this by just removing it.
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
> hashmap.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hashmap.h b/hashmap.h
> index 7ce79f3..d375d9c 100644
> --- a/hashmap.h
> +++ b/hashmap.h
> @@ -400,7 +400,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map)
> */
> static inline void hashmap_enable_item_counting(struct hashmap *map)
> {
> - void *item;
> unsigned int n = 0;
> struct hashmap_iter iter;
>
> @@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map)
> return;
>
> hashmap_iter_init(map, &iter);
> - while ((item = hashmap_iter_next(&iter)))
> + while (hashmap_iter_next(&iter))
> n++;
>
> map->do_count_items = 1;
> --
> 2.8.5.23.g6fa7ec3
>
next prev parent reply other threads:[~2018-01-15 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 18:07 [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings randall.s.becker
2018-01-15 20:43 ` Thomas Gummerer [this message]
2018-01-15 20:49 ` Randall S. Becker
2018-01-15 23:59 ` Thomas Gummerer
2018-01-16 22:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115204301.GL2641@hank \
--to=t.gummerer@gmail.com \
--cc=git@vger.kernel.org \
--cc=randall.s.becker@rogers.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).