git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: 'git mailing list' <git@vger.kernel.org>
Subject: Re: [BUG] Weird breakages in t1450 #2 on NonStop
Date: Fri, 12 Jan 2018 09:39:12 -0500	[thread overview]
Message-ID: <20180112143912.GB9088@sigill.intra.peff.net> (raw)
In-Reply-To: <000201d38b24$9e27ac40$da7704c0$@nexbridge.com>

On Thu, Jan 11, 2018 at 04:39:04PM -0500, Randall S. Becker wrote:

> > executed because the test_commit fails with a non-zero git commit
> > completion code. There is no rn---- (actual r n 252 252 252 252) in
> > the objects directory - even the 'rn' does not correspond to
> > anything.. I am suspecting an unterminated string that ran into
> > freed memory somewhere, but that's speculative.
> 
> Does anyone recall fixing this one at or near
> dfe46c5ce6e68d682f80f9874f0eb107e9fee797? There was a rewrite of
> sha1_file.c including link_alt_odb_entry where I am finding memory
> corruptions. I think I'm chasing something that was already fixed some
> time after 2.13.5 but the common parent to where I am is pretty far
> back compared to master.

I did a lot of work on link_alt_odb_entry() in the past year or so, and
I seem to recall seeing some cases where we could run into unterminated
memory in the error message.

Maybe dc732bd5cb (read_info_alternates: read contents into strbuf,
2017-09-19)?

-Peff

  reply	other threads:[~2018-01-12 14:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11 14:45 Randall S. Becker
2018-01-11 21:39 ` Randall S. Becker
2018-01-12 14:39   ` Jeff King [this message]
2018-01-12 15:47     ` Randall S. Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180112143912.GB9088@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=rsbecker@nexbridge.com \
    --subject='Re: [BUG] Weird breakages in t1450 #2 on NonStop' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).