mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: "Randall S. Becker" <>
Cc: 'git mailing list' <>
Subject: Re: [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509
Date: Thu, 11 Jan 2018 01:20:49 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <010f01d38a9e$a5c4f290$f14ed7b0$>

On Thu, Jan 11, 2018 at 12:40:05AM -0500, Randall S. Becker wrote:

> This fix was needed on HPE NonStop NSE where SSIZE_MAX is less than
> BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c
> was the only place outside of wrapper.c.

For my own curiosity, what is SSIZE_MAX on your platform? BUFFERSIZE is
only 64k. Do you really have 16-bit size_t?

I wondered if you would also need to set MAX_IO_SIZE, but it looks like
we default it to SSIZE_MAX.


  parent reply	other threads:[~2018-01-11  6:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  5:40 [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509 Randall S. Becker
2018-01-11  6:01 ` Randall S. Becker
2018-01-11  6:20 ` Jeff King [this message]
2018-01-11 13:40   ` Randall S. Becker
2018-01-11  6:31 ` Jeff King
2018-01-11 13:43   ` Randall S. Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).