From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Yasushi SHOJI <yasushi.shoji@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] bisect: debug: convert struct object to object_id
Date: Thu, 11 Jan 2018 02:08:35 +0000 [thread overview]
Message-ID: <20180111020834.GB5946@genre.crustytoothpaste.net> (raw)
In-Reply-To: <20180109110356.25824-1-yasushi.shoji@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
On Tue, Jan 09, 2018 at 08:03:56PM +0900, Yasushi SHOJI wrote:
> The commit f2fd0760f62e79609fef7bfd7ecebb002e8e4ced converted struct
> object to object_id but a debug function show_list(), which is
> ifdef'ed to noop, in bisect.c wasn't.
>
> So fix it.
Thanks. This is obviously the right change to make.
--
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]
prev parent reply other threads:[~2018-01-11 2:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 11:03 [PATCH] bisect: debug: convert struct object to object_id Yasushi SHOJI
2018-01-09 18:57 ` Junio C Hamano
2018-01-11 2:08 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111020834.GB5946@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=yasushi.shoji@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).