From: Jeff King <peff@peff.net>
To: 牛旭 <niuxu16@nudt.edu.cn>
Cc: git <git@vger.kernel.org>
Subject: Re: Recommendation for consistent update on invoke of "sha1_to_hex()"
Date: Fri, 5 Jan 2018 02:08:21 -0500 [thread overview]
Message-ID: <20180105070821.GB14251@sigill.intra.peff.net> (raw)
In-Reply-To: <fb56cfe.6744.160c45a9e5a.Coremail.niuxu16@nudt.edu.cn>
On Fri, Jan 05, 2018 at 11:26:01AM +0800, 牛旭 wrote:
> By mining historical patches, we suggest that invokes of sha1_to_hex()
> should be replaced with that of oid_to_hex(). One example for
> recommendation and corresponding patch are listed as follows.
Note that these two functions take different types. If you only have a
"const unsigned char *", then you must use sha1_to_hex(). If you have a
"struct object_id", then you should be using oid_to_hex(). If there are
sites which do:
sha1_to_hex(oid.hash)
those should be converted to use oid_to_hex(). I think there's a
coccinelle rule for this, though, so there shouldn't be any lingering
calls like that.
Of course the ultimate goal is for every function to use oid_to_hex().
But that's much bigger than a single-line change, since groups of
dependent functions need to be converted (try "git log
--author=carlson" to see example patches).
> One example of missed spot:
> 1 void assert_sha1_type(const unsigned char *sha1, enum
> object_type expect)
> 2 {
> 3 enum object_type type = sha1_object_info(sha1, NULL);
> 4 if (type < 0)
> 5 die("%s is not a valid object",sha1_to_hex(sha1));
> 6 if (type != expect)
> 7 die("%s is not a valid '%s' object", sha1_to_hex(sha1),
> 8 typename(expect));
> 9 }
So this is an example that doesn't convert easily. The function has only
the bare pointer, so you'd have to change its parameter list (and
therefore all of its callers).
-Peff
prev parent reply other threads:[~2018-01-05 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 3:26 Recommendation for consistent update on invoke of "sha1_to_hex()" 牛旭
2018-01-05 7:08 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105070821.GB14251@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=niuxu16@nudt.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).