From: Stefan Moch <stefanmoch@mail.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Simon Doodkin <helpmepro1@gmail.com>,
git@vger.kernel.org, Stefan Moch <stefanmoch@mail.de>
Subject: [PATCH 2/2] mv: remove unneeded 'if (!show_only)'
Date: Sun, 31 Dec 2017 20:11:56 +0100 [thread overview]
Message-ID: <20171231191156.28359-3-stefanmoch@mail.de> (raw)
In-Reply-To: <20171231191156.28359-1-stefanmoch@mail.de>
Commit a127331cd (mv: allow moving nested submodules,
2016-04-19), introduced
if (show_only) continue;
in this for-loop before
if (!show_only)
which became redundant, because it is now always true.
Signed-off-by: Stefan Moch <stefanmoch@mail.de>
---
builtin/mv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/builtin/mv.c b/builtin/mv.c
index cf3684d90..8ce6a2ddd 100644
--- a/builtin/mv.c
+++ b/builtin/mv.c
@@ -286,8 +286,7 @@ int cmd_mv(int argc, const char **argv, const char *prefix)
pos = cache_name_pos(src, strlen(src));
assert(pos >= 0);
- if (!show_only)
- rename_cache_entry_at(pos, dst);
+ rename_cache_entry_at(pos, dst);
}
if (gitmodules_modified)
--
2.14.3
next prev parent reply other threads:[~2017-12-31 19:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 10:53 feature-request: git "cp" like there is git mv Simon Doodkin
2017-12-13 16:39 ` Johannes Schindelin
2017-12-13 17:21 ` Randall S. Becker
2017-12-16 1:31 ` Jonathan Nieder
2017-12-31 19:11 ` Stefan Moch
2017-12-31 19:11 ` [PATCH 1/2] Add test case for mv --dry-run to t7001-mv.sh Stefan Moch
2017-12-31 19:11 ` Stefan Moch [this message]
2018-02-07 19:49 ` feature-request: git "cp" like there is git mv Junio C Hamano
2018-02-07 20:27 ` Stefan Beller
2018-03-18 20:09 ` Stefan Moch
2018-03-19 20:03 ` Junio C Hamano
2017-12-18 0:28 ` Igor Djordjevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171231191156.28359-3-stefanmoch@mail.de \
--to=stefanmoch@mail.de \
--cc=git@vger.kernel.org \
--cc=helpmepro1@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).