From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B5C651F406 for ; Thu, 28 Dec 2017 23:28:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754634AbdL1X2n (ORCPT ); Thu, 28 Dec 2017 18:28:43 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:37592 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754783AbdL1X2k (ORCPT ); Thu, 28 Dec 2017 18:28:40 -0500 Received: by mail-wr0-f194.google.com with SMTP id f8so29635958wre.4 for ; Thu, 28 Dec 2017 15:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references:mime-version:content-transfer-encoding; bh=Z2/9XnMnCMnc82QOsAk7k3P1m05Maj1z4QMb7qwvNA8=; b=EEkE0zypWrACBAa58Rbr82/e06A7nsXEyuTL0VKPJ/vmuelcq5gaKnfQYL0dib6FLb QnHyoPThubz5e6RUmmxl4TLQoHUZB0o4uo7pDCkBESGmrLx2dXnNHht/n3ZNJAt2mxTR EyBuFNNiJZp+WVfgg93whGmho4F8qguqhULt9u0t69F8t4dszQja+IecSmV4YLYYuMXr ZgtgXCTQFuEIhdogZmk5APfhVd5MAttJIVFE/7zN3n1SlZ+hvviWYSXAm1x/acspizYV HCE8U4SXv9usZlA71+k6d5ty19K7qlKHtKsiPIxAoG1pu9tN171peISbICX0B8KKeRNd b6tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references:mime-version :content-transfer-encoding; bh=Z2/9XnMnCMnc82QOsAk7k3P1m05Maj1z4QMb7qwvNA8=; b=fwOshctoWpzfNJi2xyNN5rn0GxMXNxyiTxb/oXKEkP2pfhLQku1kjYsiWTm9jCg9I2 PeP2Bv5P/i5s+WprzUAbumW8/h40E4JdFtHnEQJZjfh1Bw+A41iOi2uOLSWaGa2JY2j6 ZxlQV8rbC1ngjwjCWje6CTn23WZrhhfzcczVmt5fBcJXHJHWl5uKXKMLRXs6hRrg7tyI ApgT0hJb7Tpu+6CPERgaG333H3UcfYzg+kL6K9LRnrS0F7NXqRDknuKANZDEpaEw37oU wFn0nzokaI9gfEJY95iERFLyPhNqflCaIIyCfckatfIFDUyM0C3m40HT3QGCF5nAbUWf evlw== X-Gm-Message-State: AKGB3mLVOqo3jFp+oNOn5klPrpofS0ymfsOr+IXVDuMA/1/YNkERyzp5 0HaVYVrazffyToGSZn1eV8h2oX97 X-Google-Smtp-Source: ACJfBouLck8IsvM9fjhK2AC/lEWg8gaAY6OMf8wEUO/IVaND/EOAoQ9w19gZ2gPyvD6y9+ANCnXd/g== X-Received: by 10.223.193.141 with SMTP id x13mr24461860wre.239.1514503718976; Thu, 28 Dec 2017 15:28:38 -0800 (PST) Received: from u.nix.is ([2a01:4f8:190:5095::2]) by smtp.gmail.com with ESMTPSA id c53sm23187346wrg.10.2017.12.28.15.28.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Dec 2017 15:28:38 -0800 (PST) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= , Anthony Ramine , Ramsay Jones , Johannes Sixt , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH v3 2/7] wildmatch test: use more standard shell style Date: Thu, 28 Dec 2017 23:28:18 +0000 Message-Id: <20171228232823.14450-3-avarab@gmail.com> X-Mailer: git-send-email 2.15.1.424.g9478a66081 In-Reply-To: <20171228232823.14450-1-avarab@gmail.com> References: <20171228232823.14450-1-avarab@gmail.com> In-Reply-To: <20171225002835.29005-1-avarab@gmail.com> References: <20171225002835.29005-1-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Change the wildmatch test to use more standard shell style, usually we use "if test" not "if [". Signed-off-by: Ævar Arnfjörð Bjarmason --- t/t3070-wildmatch.sh | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh index 27fa878f6e..4d589d1f9a 100755 --- a/t/t3070-wildmatch.sh +++ b/t/t3070-wildmatch.sh @@ -5,7 +5,8 @@ test_description='wildmatch tests' . ./test-lib.sh match() { - if [ $1 = 1 ]; then + if test "$1" = 1 + then test_expect_success "wildmatch: match '$3' '$4'" " test-wildmatch wildmatch '$3' '$4' " @@ -17,7 +18,8 @@ match() { } imatch() { - if [ $1 = 1 ]; then + if test "$1" = 1 + then test_expect_success "iwildmatch: match '$2' '$3'" " test-wildmatch iwildmatch '$2' '$3' " @@ -29,7 +31,8 @@ imatch() { } pathmatch() { - if [ $1 = 1 ]; then + if test "$1" = 1 + then test_expect_success "pathmatch: match '$2' '$3'" " test-wildmatch pathmatch '$2' '$3' " -- 2.15.1.424.g9478a66081