From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Jeff Hostetler <jeffhost@microsoft.com>,
Johannes Sixt <j6t@kdbg.org>,
git-for-windows@googlegroups.com
Subject: Re: [PATCH 2/2] Windows: stop supplying BLK_SHA1=YesPlease by default
Date: Wed, 27 Dec 2017 15:42:37 -0800 [thread overview]
Message-ID: <20171227234237.GC181628@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20171227230038.14386-3-avarab@gmail.com>
+git-for-windows
Ævar Arnfjörð Bjarmason wrote:
> Using BLK_SHA1 in lieu of the OpenSSL routines was done in [1], but
> since DC_SHA1 is now the default for git in general it makes sense for
> Windows to use that too, this looks like something that was missed
> back in [2].
>
> As noted in [3] OpenSSL has a performance benefit compared to BLK_SHA1
> on MinGW, so perhaps that and the Windows default should be changed
> around again, but that's a topic for another series, it seems clear
> that this specific flag is nobody's explicit intention.
I have some memory of performance issues on Windows when DC_SHA1 was
introduced leading to interest in a mixed configuration with DC_SHA1
only being used where it is security sensitive (e.g. for object naming
but not for packfile trailers).
Did anything come of that?
In any event removing this BLK_SHA1 setting looks like a good change
to me, but I'd rather that Windows folks weigh in.
Thanks,
Jonathan
[...]
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -361,7 +361,6 @@ ifeq ($(uname_S),Windows)
> NO_REGEX = YesPlease
> NO_GETTEXT = YesPlease
> NO_PYTHON = YesPlease
> - BLK_SHA1 = YesPlease
> ETAGS_TARGET = ETAGS
> NO_INET_PTON = YesPlease
> NO_INET_NTOP = YesPlease
next prev parent reply other threads:[~2017-12-27 23:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 23:00 [PATCH 0/2] When DC_SHA1 was made the default we missed a spot Ævar Arnfjörð Bjarmason
2017-12-27 23:00 ` [PATCH 1/2] Makefile: NO_OPENSSL=1 should no longer imply BLK_SHA1=1 Ævar Arnfjörð Bjarmason
2017-12-27 23:39 ` Jonathan Nieder
2017-12-28 14:07 ` [PATCH v2 0/2] When DC_SHA1 was made the default we missed a spot Ævar Arnfjörð Bjarmason
2017-12-28 14:07 ` [PATCH v2 1/2] Makefile: NO_OPENSSL=1 should no longer imply BLK_SHA1=1 Ævar Arnfjörð Bjarmason
2017-12-28 19:05 ` Jonathan Nieder
2017-12-28 14:07 ` [PATCH v2 2/2] Windows: stop supplying BLK_SHA1=YesPlease by default Ævar Arnfjörð Bjarmason
2017-12-28 19:04 ` Jonathan Nieder
2018-01-04 17:33 ` Johannes Schindelin
2018-01-04 18:30 ` Ævar Arnfjörð Bjarmason
2018-01-05 18:52 ` Junio C Hamano
2017-12-27 23:00 ` [PATCH " Ævar Arnfjörð Bjarmason
2017-12-27 23:42 ` Jonathan Nieder [this message]
2017-12-28 13:47 ` Ævar Arnfjörð Bjarmason
2018-01-04 17:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227234237.GC181628@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git-for-windows@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).