From: Stefan Beller <sbeller@google.com>
To: jrnieder@gmail.com, gitster@pobox.com
Cc: git@vger.kernel.org, Stefan Beller <sbeller@google.com>
Subject: [PATCHv2 0/4] Fix --recurse-submodules for submodule worktree changes
Date: Wed, 20 Dec 2017 14:17:21 -0800 [thread overview]
Message-ID: <20171220221725.129162-1-sbeller@google.com> (raw)
v2:
* squashed the test patch and the bugfix, rewriting the commit message entirely.
This might not the way Jonathan imagined how I address the potential user
confusion[1], but I think it does the job.
[1] https://public-inbox.org/git/20171220000148.GJ240141@aiede.mtv.corp.google.com/
v1:
The fix is in the last patch, the first patches are just massaging the code
base to make the fix easy.
The second patch fixes a bug in the test, which was ineffective at testing.
The third patch shows the problem this series addresses,
the fourth patch is a little refactoring, which I want to keep separate
as I would expect it to be a performance regression[1].
The first patch is unrelated, but improves the readability of submodule test
cases, which we'd want to improve further.
Thanks,
Stefan
[1] The performance should improve once we don't use so many processes
any more, but that repository series is stalled for now.
Stefan Beller (4):
t/lib-submodule-update.sh: clarify test
t/lib-submodule-update.sh: Fix test ignoring ignored files in
submodules
unpack-trees: Fix same() for submodules
submodule: submodule_move_head omits old argument in forced case
submodule.c | 4 +++-
t/lib-submodule-update.sh | 16 ++++++++++++++--
unpack-trees.c | 2 ++
3 files changed, 19 insertions(+), 3 deletions(-)
--
2.15.1.620.gb9897f4670-goog
next reply other threads:[~2017-12-20 22:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 22:17 Stefan Beller [this message]
2017-12-20 22:17 ` [PATCH 1/4] t/lib-submodule-update.sh: clarify test Stefan Beller
2017-12-20 22:17 ` [PATCH 2/4] t/lib-submodule-update.sh: Fix test ignoring ignored files in submodules Stefan Beller
2017-12-20 22:17 ` [PATCH 3/4] unpack-trees: Fix same() for submodules Stefan Beller
2017-12-22 19:57 ` Junio C Hamano
2017-12-20 22:17 ` [PATCH 4/4] submodule: submodule_move_head omits old argument in forced case Stefan Beller
2017-12-22 20:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220221725.129162-1-sbeller@google.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).