From: Todd Zullinger <tmz@pobox.com>
To: Michael J Gruber <git@grubix.eu>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Randall S. Becker" <rsbecker@nexbridge.com>,
git@vger.kernel.org, "'Junio C Hamano'" <gitster@pobox.com>,
"'Jeff King'" <peff@peff.net>, "'Dan Jacques'" <dnj@google.com>,
"'Alex Riesen'" <alexander.riesen@cetitec.com>,
"'Jonathan Nieder'" <jrnieder@gmail.com>,
"'Brandon Casey'" <drafnel@gmail.com>,
"'Petr Baudis'" <pasky@ucw.cz>,
"'Gerrit Pape'" <pape@smarden.org>,
"'martin f . krafft'" <madduck@madduck.net>,
"'Eric Wong'" <e@80x24.org>,
"'Ramsay Jones'" <ramsay@ramsayjones.plus.com>,
"'Joachim Schmitz'" <jojo@schmitz-digital.de>,
"Bill Honaker" <bhonaker@xid.com>
Subject: Re: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules
Date: Fri, 15 Dec 2017 10:09:10 -0500 [thread overview]
Message-ID: <20171215150910.GI3693@zaya.teonanacatl.net> (raw)
In-Reply-To: <b8b4534f-1eda-ee52-faed-ec5188c2ad35@grubix.eu>
Hi Michael,
Michael J Gruber wrote:
> This patch (currently in origin/next) makes a ton of tests from our test
> suite fail for me on pretty standard systems (Fedora 27, CentOS 7.4.1708).
>
> Is there anything I'm supposed to do differently now to make our test
> suite run? If yes then a clear and short hint in the patch description
> would me more than approriate.
Interesting. I'll have to try building next. I was going
to wait until the first 2.16.0 rc for a full test.
I did apply this patch on top of 2.15.1 on 12/10 and built
an rpm locally for fedora (only f26 though). I didn't see
any test failures, which is why I thought I'd wait for
2.16.0-rc0 to test further.
FWIW, the minor spec file changes I made (against fedora's
git package master branch) are here:
https://src.fedoraproject.org/fork/tmz/rpms/git/branch/perl-makefile
The only change in the patch since I tested it is:
+-modules += Git/Packet
in perl/Makefile.
I don't think any of these changes to the rpm spec file or
the Git/Packet addition in modules look like they'd affect
the test suite, but it's early here and I could be wrong.
I'll try to test a build of next soon to see if I get
similar failures on Fedora/CentOS.
--
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
After one look at this planet any visitor from outer space would say
"I want to see the manager."
-- William S. Burroughs
next prev parent reply other threads:[~2017-12-15 15:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 15:34 [RFC/PATCH] Makefile: replace the overly complex perl build system with something simple Ævar Arnfjörð Bjarmason
2017-11-29 19:54 ` [PATCH] Makefile: replace perl/Makefile.PL with simple make rules Ævar Arnfjörð Bjarmason
2017-11-30 2:11 ` Jonathan Nieder
2017-11-30 9:37 ` Ævar Arnfjörð Bjarmason
2017-11-30 20:59 ` Jonathan Nieder
2017-11-30 21:16 ` Eric Wong
2017-11-30 21:31 ` Jeff King
2017-11-30 22:30 ` Ævar Arnfjörð Bjarmason
2017-12-21 19:29 ` Alex Vandiver
2017-12-03 11:59 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2017-12-04 16:22 ` Junio C Hamano
2017-12-04 18:08 ` Ævar Arnfjörð Bjarmason
2017-12-04 19:42 ` Junio C Hamano
2017-12-04 19:51 ` Dan Jacques
2017-12-10 21:13 ` [PATCH v3] " Ævar Arnfjörð Bjarmason
2017-12-11 23:29 ` Junio C Hamano
2017-12-12 21:33 ` Randall S. Becker
2017-12-12 22:26 ` Ævar Arnfjörð Bjarmason
2017-12-15 10:35 ` Michael J Gruber
2017-12-15 15:09 ` Todd Zullinger [this message]
2017-12-15 17:31 ` Ævar Arnfjörð Bjarmason
2017-12-19 15:53 ` Junio C Hamano
2017-12-19 23:57 ` [PATCH v4] " Ævar Arnfjörð Bjarmason
2017-12-20 6:15 ` Todd Zullinger
2017-12-20 11:52 ` [PATCH v5] " Ævar Arnfjörð Bjarmason
2017-12-20 17:41 ` Todd Zullinger
2017-12-20 18:24 ` [PATCH v6] " Ævar Arnfjörð Bjarmason
2017-12-20 20:17 ` Todd Zullinger
2017-12-21 7:22 ` Alex Riesen
2017-12-22 19:07 ` Junio C Hamano
2017-12-27 22:24 ` Ævar Arnfjörð Bjarmason
2017-12-28 18:36 ` Junio C Hamano
2018-01-02 19:17 ` Jonathan Nieder
2018-01-02 20:01 ` [PATCH ab/simplify-perl-makefile] perl: treat PERLLIB_EXTRA as an extra path again (Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules) Jonathan Nieder
2018-01-02 20:39 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215150910.GI3693@zaya.teonanacatl.net \
--to=tmz@pobox.com \
--cc=alexander.riesen@cetitec.com \
--cc=avarab@gmail.com \
--cc=bhonaker@xid.com \
--cc=dnj@google.com \
--cc=drafnel@gmail.com \
--cc=e@80x24.org \
--cc=git@grubix.eu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jojo@schmitz-digital.de \
--cc=jrnieder@gmail.com \
--cc=madduck@madduck.net \
--cc=pape@smarden.org \
--cc=pasky@ucw.cz \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).