From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Stefan Beller <sbeller@google.com>,
Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] hashmap: adjust documentation to reflect reality
Date: Fri, 8 Dec 2017 04:03:46 -0500 [thread overview]
Message-ID: <20171208090346.GB26199@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.21.1.1712072244040.4318@virtualbox>
On Thu, Dec 07, 2017 at 10:47:43PM +0100, Johannes Schindelin wrote:
> > We could add that example to the test helper as then we have a good (tested)
> > example for that case, too.
>
> What we could *also* do, and what would probably make *even more* sense,
> is to simplify the example drastically, to a point where testing it in
> test-hashmap is pointless, and where a reader can gather *very* quickly
> what it takes to use the hashmap routines.
Yes, I'd be in favor of that, too.
> In any case, I would really like to see my patch applied first, as it is a
> separate concern from what you gentle people talk about: I simply want
> that incorrect documentation fixed. The earlier, the better.
Definitely. I think it is in "next" already.
-Peff
prev parent reply other threads:[~2017-12-08 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 23:51 [PATCH] hashmap: adjust documentation to reflect reality Johannes Schindelin
2017-11-30 0:16 ` Jonathan Nieder
2017-11-30 3:07 ` Jeff King
2017-12-03 5:35 ` Junio C Hamano
2017-12-04 19:08 ` Stefan Beller
2017-12-07 21:47 ` Johannes Schindelin
2017-12-08 9:03 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208090346.GB26199@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).