From: Jeff King <peff@peff.net>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
lars.schneider@autodesk.com, git@vger.kernel.org,
gitster@pobox.com, sbeller@google.com, sunshine@sunshineco.com,
sandals@crustytoothpaste.net
Subject: Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input
Date: Mon, 4 Dec 2017 17:09:09 -0500 [thread overview]
Message-ID: <20171204220908.GA8184@sigill.intra.peff.net> (raw)
In-Reply-To: <787AD800-7169-4B83-A1AD-171A15D103B9@gmail.com>
On Mon, Dec 04, 2017 at 10:54:40PM +0100, Lars Schneider wrote:
> > Better, IMHO, though I still think literally saying:
> >
> > hint: Waiting for your editor to exit...
> >
> > is the most accurate, which I think makes it clear that you must _exit_
> > your editor, not just save and close the file.
>
> I think "exit" would be confusing because most graphical editors (Sublime,
> Textmate, Notepad++, ...) can open multiple files and do not need to exit.
> The requirement is indeed save and close the file.
>
> How about:
>
> hint: Waiting for your editor to close the file...
>
> I generally like that as this is technical correct from all angles.
> My only nit would be that "the file" is a bit imprecise... but
> that's probably no problem.
OK, that makes sense. There are two definitions of "exit" here. We care
about the process exiting, but of course the editor may present a
concept of "exiting" to the user that is different.
I know emacsclient behaves that way (the client process exits when the
buffer is closed, even though the rest of emacs may still be running),
but I didn't realize other editors did so. I know atom doesn't, but then
it also exits immediately, making it inappropriate for $GIT_EDITOR in
the first place.
-Peff
next prev parent reply other threads:[~2017-12-04 22:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 14:37 [PATCH v4 0/2] launch_editor(): indicate that Git waits for user input lars.schneider
2017-11-29 14:37 ` [PATCH v4 1/2] refactor "dumb" terminal determination lars.schneider
2017-11-30 20:30 ` Jeff King
2017-12-01 3:26 ` Kaartic Sivaraam
2017-11-29 14:37 ` [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input lars.schneider
2017-11-30 20:51 ` Jeff King
2017-12-01 3:56 ` Kaartic Sivaraam
2017-12-01 12:52 ` Lars Schneider
2017-12-01 18:29 ` Jeff King
2017-12-02 3:45 ` Kaartic Sivaraam
2017-12-03 16:39 ` Lars Schneider
2017-12-04 16:41 ` Kaartic Sivaraam
2017-12-04 17:26 ` Jeff King
2017-12-04 21:31 ` Lars Schneider
2017-12-04 21:42 ` Jeff King
2017-12-04 21:54 ` Lars Schneider
2017-12-04 22:09 ` Jeff King [this message]
2017-12-04 17:25 ` Jeff King
2017-12-03 5:15 ` Junio C Hamano
2017-12-03 12:47 ` Lars Schneider
2017-12-04 17:32 ` Jeff King
2017-12-04 21:34 ` Lars Schneider
2017-12-04 21:40 ` Junio C Hamano
2017-12-04 17:30 ` Jeff King
2017-11-29 18:35 ` [PATCH v4 0/2] " Thomas Adam
2017-11-30 13:55 ` Lars Schneider
2017-11-30 14:42 ` Thomas Adam
2017-11-30 15:13 ` Andreas Schwab
2017-12-01 3:41 ` Kaartic Sivaraam
2017-11-30 20:12 ` Jeff King
2017-11-30 20:51 ` Thomas Adam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204220908.GA8184@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=lars.schneider@autodesk.com \
--cc=larsxschneider@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).