git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ben Boeckel <ben.boeckel@kitware.com>
To: git@vger.kernel.org
Cc: bmwill@google.com, brad.king@kitware.com
Subject: gitattributes not read for diff-tree anymore in 2.15?
Date: Mon, 4 Dec 2017 16:22:55 -0500	[thread overview]
Message-ID: <20171204212255.GA19059@megas.kitware.com> (raw)

Hi,

I've bisected a failure in our test suite to this commit:

    commit 557a5998df19faf8641acfc5b6b1c3c2ba64dca9 (HEAD, refs/bisect/bad)
    Author: Brandon Williams <bmwill@google.com>
    Date:   Thu Aug 3 11:20:00 2017 -0700

        submodule: remove gitmodules_config

        Now that the submodule-config subsystem can lazily read the gitmodules
        file we no longer need to explicitly pre-read the gitmodules by calling
        'gitmodules_config()' so let's remove it.

        Signed-off-by: Brandon Williams <bmwill@google.com>
        Signed-off-by: Junio C Hamano <gitster@pobox.com>

Which is tags/v2.15.0-rc0~120^2.

Our test suite is in a Rust project here:

    https://gitlab.kitware.com/utils/rust-git-checks

and the failing test(s) can be run using:

    cargo test whitespace_all_ignored

The test checks that when `.gitattributes` says that whitespace errors
should be ignored, they aren't reported as errors. My guess is that not
reading the gitmodules configuration also skips reading attributes
files. Is this reasoning correct?

Thanks,

--Ben

             reply	other threads:[~2017-12-04 21:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 21:22 Ben Boeckel [this message]
2017-12-04 23:03 ` gitattributes not read for diff-tree anymore in 2.15? Brandon Williams
2017-12-05 15:42   ` Ben Boeckel
2017-12-05 18:16     ` Brandon Williams
2017-12-05 19:48       ` Ben Boeckel
2017-12-05 22:13         ` [PATCH] diff-tree: read the index so attribute checks work in bare repositories Brandon Williams
2017-12-05 22:29           ` Ben Boeckel
2017-12-05 22:31             ` Brandon Williams
2017-12-05 23:13           ` Junio C Hamano
2017-12-05 23:14           ` Stefan Beller
2017-12-06 21:47             ` Brandon Williams
2017-12-05 23:25           ` Eric Sunshine
2017-12-06 22:00             ` Brandon Williams
2017-12-06 22:07               ` Eric Sunshine
2017-12-06 22:02           ` [PATCH v2] " Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204212255.GA19059@megas.kitware.com \
    --to=ben.boeckel@kitware.com \
    --cc=bmwill@google.com \
    --cc=brad.king@kitware.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).