git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Todd Zullinger <tmz@pobox.com>
To: git@vger.kernel.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test
Date: Thu, 30 Nov 2017 21:32:37 -0500	[thread overview]
Message-ID: <20171201023239.26153-1-tmz@pobox.com> (raw)

These tests are not run by default nor are they enabled in travis-ci.  I
don't know how much testing they get in user or other packager builds.

I've been slowly increasing the test suite usage in fedora builds.  I
ran into this while testing locally with parallel make test.  The
official fedora builds don't run in parallel (yet), as even before I ran
into this issue, builds on the fedora builders randomly failed too
often.  I'm hoping to eventually enable parallel tests by default
though, since it's so much faster.

I'm not sure if there's any objection to changing the variable needed to
enable the tests from SVNSERVE_PORT to GIT_TEST_SVNSERVE.  The way
SVNSERVE_PORT is set in this patch should allow the port to be set
explicitly, in case someone requires that -- and they understand that it
can fail if running parallel tests, of course.  Whether that's a
feature or a bug, I'm not sure. :)

The indentation of lib-git-svn.sh didn't use tabs consistently, in only
a few places, so I cleaned that up first.  I can drop that change if
it's unwanted.

Todd Zullinger (2):
  t/lib-git-svn: whitespace cleanup
  t/lib-git-svn.sh: improve svnserve tests with parallel make test

 t/lib-git-svn.sh | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

-- 
2.15.1


             reply	other threads:[~2017-12-01  2:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01  2:32 Todd Zullinger [this message]
2017-12-01  2:32 ` [PATCH 1/2] t/lib-git-svn: whitespace cleanup Todd Zullinger
2017-12-01  3:04   ` Jonathan Nieder
2017-12-01  3:42     ` Todd Zullinger
2017-12-01  3:56       ` Jonathan Nieder
2017-12-01  2:32 ` [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test Todd Zullinger
2017-12-01  3:02   ` Jonathan Nieder
2017-12-01  3:45     ` Todd Zullinger
2017-12-01  3:53       ` Jonathan Nieder
2017-12-01  4:11         ` Todd Zullinger
2017-12-01 15:56           ` [PATCH v2 1/2] t/lib-git-svn: cleanup inconsistent tab/space usage Todd Zullinger
     [not found]           ` <20171201153241.27071-1-tmz@pobox.com>
2017-12-01 15:56             ` [PATCH v2 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test Todd Zullinger
2017-12-01 20:06               ` Jonathan Nieder
2017-12-01  2:56 ` [PATCH 0/2] " Eric Wong
2017-12-01  3:40   ` Todd Zullinger
2017-12-01  3:07 ` Jonathan Nieder
2017-12-01  3:40   ` Todd Zullinger
2017-12-14 18:19 ` Todd Zullinger
2017-12-14 18:45   ` Junio C Hamano
2017-12-14 20:35     ` Todd Zullinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201023239.26153-1-tmz@pobox.com \
    --to=tmz@pobox.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).