From: Max Kirillov <max@max630.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Max Kirillov <max@max630.net>,
Eric Sunshine <sunshine@sunshineco.com>,
Jeff King <peff@peff.net>,
Florian Manschwetus <manschwetus@cs-software-gmbh.de>,
Chris Packham <judge.packham@gmail.com>,
Konstantin Khomoutov <kostix+git@007spb.ru>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875
Date: Sun, 26 Nov 2017 10:13:30 +0200 [thread overview]
Message-ID: <20171126081329.GD26158@jessie.local> (raw)
In-Reply-To: <xmqqo9npitx7.fsf@gitster.mtv.corp.google.com>
On Sun, Nov 26, 2017 at 12:46:12PM +0900, Junio C Hamano wrote:
> Max Kirillov <max@max630.net> writes:
> > +ssize_t git_env_ssize_t(const char *k, ssize_t val)
> > +{
> > + const char *v = getenv(k);
> > + if (v && !git_parse_ssize_t(v, &val))
> > + die("failed to parse %s", k);
> > + return val;
> > +}
> > +
>
> If this were passing "v" that is a string the caller obtains from
> any source (and the callee does not care about where it came from),
> that would be a different story, but as a public interface that is
> part of the config.c layer, "k" that has to be the name of the
> environment variable sticks out like a sore thumb.
>
> If we were to add one more public function to the interface, I
> suspect that exposing the existing git_parse_ssize_t() and have the
> caller implement the above function for its use would be a much
> better way to go.
I'm afraid I did not get the reasonsing and not fully the
desired change. Is this http-backend code change (compared
to the last patch) what you mean?
--- a/http-backend.c
+++ b/http-backend.c
@@ -346,9 +346,18 @@ static ssize_t read_request_fixed_len(int fd, ssize_t req_len, unsigned char **o
}
}
+static ssize_t env_content_length()
+{
+ const char *str = getenv("CONTENT_LENGTH");
+ ssize_t val = -1;
+ if (str && !git_parse_ssize_t(str, &val))
+ die("failed to parse CONTENT_LENGTH: %s", str);
+ return val;
+}
+
static ssize_t read_request(int fd, unsigned char **out)
{
- ssize_t req_len = git_env_ssize_t("CONTENT_LENGTH", -1);
+ ssize_t req_len = env_content_length();
if (req_len < 0)
return read_request_eof(fd, out);
else
next prev parent reply other threads:[~2017-11-26 8:13 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 10:38 [PATCH] Fix http-backend reading till EOF, ignoring CONTENT_LENGTH, violating rfc3875 -- WAS: Problem with git-http-backend.exe as iis cgi Florian Manschwetus
2016-03-29 20:13 ` Jeff King
2016-03-30 9:08 ` AW: " Florian Manschwetus
2016-04-01 23:55 ` Jeff King
2017-11-23 23:45 ` [PATCH] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2017-11-24 1:30 ` Eric Sunshine
2017-11-25 21:47 ` Max Kirillov
2017-11-26 0:38 ` Eric Sunshine
2017-11-26 0:43 ` Max Kirillov
2017-11-24 5:54 ` Junio C Hamano
2017-11-24 8:30 ` AW: " Florian Manschwetus
2017-11-26 1:50 ` Max Kirillov
2017-11-26 1:47 ` [PATCH v4 0/2] " Max Kirillov
2017-11-26 1:47 ` [PATCH v4 1/2] " Max Kirillov
2017-11-26 1:47 ` [PATCH v4 2/2] t5560-http-backend-noserver.sh: add CONTENT_LENGTH cases Max Kirillov
2017-11-26 1:54 ` [PATCH v5 0/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2017-11-26 1:54 ` [PATCH v5 1/2] " Max Kirillov
2017-11-26 3:46 ` Junio C Hamano
2017-11-26 8:13 ` Max Kirillov [this message]
2017-11-26 9:38 ` Junio C Hamano
2017-11-26 19:39 ` Max Kirillov
2017-11-26 1:54 ` [PATCH v5 2/2] t5560-http-backend-noserver.sh: add CONTENT_LENGTH cases Max Kirillov
2017-11-26 19:38 ` [PATCH v6 0/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2017-11-26 19:38 ` [PATCH v6 1/2] " Max Kirillov
2017-11-26 22:08 ` Eric Sunshine
2017-11-29 3:22 ` Jeff King
2017-12-03 1:02 ` Junio C Hamano
2017-12-03 2:49 ` Jeff King
2017-12-03 6:07 ` Junio C Hamano
2017-12-04 7:18 ` AW: " Florian Manschwetus
2017-12-04 17:13 ` Jeff King
2017-11-26 19:38 ` [PATCH v6 2/2] t5560-http-backend-noserver.sh: add CONTENT_LENGTH cases Max Kirillov
2017-11-26 22:18 ` Eric Sunshine
2017-11-26 22:40 ` Max Kirillov
2017-11-29 3:26 ` Jeff King
2017-11-29 5:19 ` Max Kirillov
2017-12-03 0:46 ` Junio C Hamano
2017-11-27 0:29 ` Junio C Hamano
2017-11-27 4:02 ` [PATCH v6 0/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Junio C Hamano
2017-11-29 5:07 ` Max Kirillov
2017-12-03 0:48 ` Junio C Hamano
2017-12-12 16:17 ` Need to add test artifacts to .gitignore Dan Jacques
2017-12-12 19:00 ` [RFC PATCH] t/helper: Move sources to t/helper-src; gitignore any files in t/helper Stefan Beller
2017-12-12 19:59 ` Junio C Hamano
2017-12-12 20:56 ` [PATCH] t/helper: ignore everything but sources Stefan Beller
2017-12-12 21:06 ` Junio C Hamano
2017-12-13 20:12 ` Stefan Beller
2017-12-12 21:06 ` Todd Zullinger
2017-12-19 22:13 ` [PATCH v6 0/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Junio C Hamano
2017-12-20 4:30 ` Max Kirillov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171126081329.GD26158@jessie.local \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=judge.packham@gmail.com \
--cc=kostix+git@007spb.ru \
--cc=manschwetus@cs-software-gmbh.de \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).