From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
git@vger.kernel.org, git@jeffhostetler.com
Subject: Re: [PATCH 0/3] Introduce BUG_ON(cond, msg) MACRO
Date: Wed, 22 Nov 2017 18:39:05 -0500 [thread overview]
Message-ID: <20171122233905.GC8577@sigill> (raw)
In-Reply-To: <20171122232814.GH11671@aiede.mtv.corp.google.com>
On Wed, Nov 22, 2017 at 03:28:14PM -0800, Jonathan Nieder wrote:
> > I do like human readable messages. But sometimes such a message just
> > makes the code harder to read (and to write). E.g., is there any real
> > value in:
> >
> > BUG_ON(!foo, "called bar() with a foo!");
> >
> > over:
> >
> > assert(foo);
>
> I think you're hinting at wanting
>
> BUG_ON(!foo);
>
> which is something that the Linux kernel has (and which is not done in
> this series).
Yes. I'd be fine having a single-argument BUG_ON() like that. But then,
I'm not sure what it's buying us over assert().
I get why the kernel cannot use the default "dump core and exit"
behavior of assert(), but that's basically what our BUG() does.
-Peff
next prev parent reply other threads:[~2017-11-22 23:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 22:38 [PATCH 0/3] Introduce BUG_ON(cond, msg) MACRO Stefan Beller
2017-11-22 22:38 ` [PATCH 1/3] Documentation/CodingGuidelines: explain why assert is bad Stefan Beller
2017-11-22 22:59 ` Jonathan Nieder
2017-11-22 23:08 ` Stefan Beller
2017-11-22 23:54 ` Jonathan Nieder
2017-11-22 22:38 ` [PATCH 2/3] git-compat: introduce BUG_ON(condition, fmt, ...) macro Stefan Beller
2017-11-22 23:02 ` Jonathan Nieder
2017-11-22 23:37 ` Jeff King
2017-11-22 22:38 ` [PATCH 3/3] contrib/coccinelle: convert all conditional bugs to bug_on Stefan Beller
2017-11-22 23:24 ` [PATCH 0/3] Introduce BUG_ON(cond, msg) MACRO Jeff King
2017-11-22 23:28 ` Jonathan Nieder
2017-11-22 23:39 ` Jeff King [this message]
2017-11-22 23:45 ` Jonathan Nieder
2017-11-22 23:58 ` Jeff King
2017-11-23 0:08 ` Jonathan Nieder
2017-11-23 0:10 ` Jeff King
2017-11-23 1:38 ` Junio C Hamano
2017-11-23 5:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122233905.GC8577@sigill \
--to=peff@peff.net \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).