git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Beat Bolli <dev+git@drbeat.li>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] contrib/git-jump: allow to configure the grep command
Date: Mon, 20 Nov 2017 14:20:11 -0500	[thread overview]
Message-ID: <20171120192011.i3nsulvnswshwdlr@sigill.intra.peff.net> (raw)
In-Reply-To: <20171119230536.1628-1-dev+git@drbeat.li>

On Mon, Nov 20, 2017 at 12:05:36AM +0100, Beat Bolli wrote:

> Add the configuration option "jump.grepCmd" that allows to configure the
> command that is used to search in grep mode. This allows the users of
> git-jump to use ag(1) or ack(1) as search engines.

This patch looks good to me. The user needs to be careful to use some
option that shows the line number, but that's hopefully obvious from
your example.

> +# use the silver searcher for git jump grep
> +git config jump.grepCmd "ag --column"

I wondered what "vim -q" would do with the --column output. Quite
nicely, it puts the cursor right where you'd want it to be. I'm tempted
to teach "git grep" the same option. ;)

-Peff

  parent reply	other threads:[~2017-11-20 19:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-19 23:05 [PATCH] contrib/git-jump: allow to configure the grep command Beat Bolli
2017-11-20  3:11 ` Junio C Hamano
2017-11-20 19:18   ` Jeff King
2017-11-20 19:55     ` Jonathan Nieder
2017-11-21  1:58     ` Junio C Hamano
2017-11-20 19:20 ` Jeff King [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-11-09 20:30 Beat Bolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171120192011.i3nsulvnswshwdlr@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).