From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id A7E0E202AF for ; Fri, 17 Nov 2017 22:03:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936642AbdKQWDD (ORCPT ); Fri, 17 Nov 2017 17:03:03 -0500 Received: from cloud.peff.net ([104.130.231.41]:32966 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S936637AbdKQWDC (ORCPT ); Fri, 17 Nov 2017 17:03:02 -0500 Received: (qmail 8957 invoked by uid 109); 17 Nov 2017 22:03:02 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 17 Nov 2017 22:03:02 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 28871 invoked by uid 111); 17 Nov 2017 22:03:17 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with ESMTPA; Fri, 17 Nov 2017 17:03:17 -0500 Authentication-Results: peff.net; auth=pass (cram-md5) smtp.auth=relayok Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 17 Nov 2017 17:03:00 -0500 Date: Fri, 17 Nov 2017 17:03:00 -0500 From: Jeff King To: Luke Diamand Cc: Stefan Beller , Git Users , Duy Nguyen Subject: Re: Bug in "revision.c: --all adds HEAD from all worktrees" ? Message-ID: <20171117220300.5zvyjwxgi2425m7z@sigill.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Nov 15, 2017 at 09:38:26PM +0000, Luke Diamand wrote: > >> Quite a few of the worktrees have expired - their head revision has > >> been GC'd and no longer points to anything sensible > >> (gc.worktreePruneExpire). The function other_head_refs() in worktree.c > >> bails out if there's an error, which I think is the problem. I wonder > >> if it should instead just report something and then keep going. > > > > Also see > > https://public-inbox.org/git/CAGZ79kYP0z1G_H3nwfmSHraWHMBOcik5LepUXKj0nveeBrihiw@mail.gmail.com/ > > So is this a bug or user error on my part? It's a bug. You didn't do anything wrong, but the worktree feature corrupted your repository. -Peff