From: Joel Teichroeb <joel@teichroeb.net>
To: Git Mailing List <git@vger.kernel.org>,
Thomas Gummerer <t.gummerer@gmail.com>, Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Joel Teichroeb <joel@teichroeb.net>
Subject: [PATCH 1/2] merge: close the index lock when not writing the new index
Date: Fri, 10 Nov 2017 15:13:13 -0800 [thread overview]
Message-ID: <20171110231314.30711-2-joel@teichroeb.net> (raw)
In-Reply-To: <20171110231314.30711-1-joel@teichroeb.net>
If the merge does not have anything to do, it does not unlock the index,
causing any further index operations to fail. Thus, always unlock the index
regardless of outcome.
Signed-off-by: Joel Teichroeb <joel@teichroeb.net>
---
merge-recursive.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/merge-recursive.c b/merge-recursive.c
index 2ca8444c6..225ff3fb5 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -2184,9 +2184,12 @@ int merge_recursive_generic(struct merge_options *o,
if (clean < 0)
return clean;
- if (active_cache_changed &&
- write_locked_index(&the_index, &lock, COMMIT_LOCK))
- return err(o, _("Unable to write index."));
+ if (active_cache_changed) {
+ if (write_locked_index(&the_index, &lock, COMMIT_LOCK))
+ return err(o, _("Unable to write index."));
+ } else {
+ rollback_lock_file(&lock);
+ }
return clean ? 0 : 1;
}
--
2.15.0
next prev parent reply other threads:[~2017-11-10 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 23:13 [PATCH 0/2] Convert some stash functionality to a builtin Joel Teichroeb
2017-11-10 23:13 ` Joel Teichroeb [this message]
2017-11-13 21:12 ` [PATCH 1/2] merge: close the index lock when not writing the new index Martin Ågren
2017-11-10 23:13 ` [PATCH 2/2] stash: implement builtin stash helper Joel Teichroeb
2017-11-12 15:27 ` Thomas Gummerer
2017-11-12 17:21 ` Joel Teichroeb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110231314.30711-2-joel@teichroeb.net \
--to=joel@teichroeb.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).