git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Tan <jonathantanmy@google.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
	Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v3 6/6] pack-objects: add list-objects filtering
Date: Tue, 7 Nov 2017 16:45:19 -0800	[thread overview]
Message-ID: <20171107164519.eb49377ce11a6b31ab09bf83@google.com> (raw)
In-Reply-To: <20171107193546.10017-7-git@jeffhostetler.com>

On Tue,  7 Nov 2017 19:35:46 +0000
Jeff Hostetler <git@jeffhostetler.com> wrote:

> +--filter-ignore-missing:
> +	Ignore missing objects without error.  This may be used with
> +	or without and of the above filtering.

There is a discussion about this parameter (and the corresponding ones
in patch 5/6), to which I have just replied:

https://public-inbox.org/git/20171107164118.97cc65c4030de0922b19ddd6@google.com/

> @@ -3028,6 +3048,12 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
>  	if (!rev_list_all || !rev_list_reflog || !rev_list_index)
>  		unpack_unreachable_expiration = 0;
>  
> +	if (filter_options.choice) {
> +		if (!pack_to_stdout)
> +			die("cannot use filtering with an indexable pack.");

I'm not sure what an "indexable pack" is - probably a better message is
"cannot use --filter without --stdout".

  reply	other threads:[~2017-11-08  0:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 19:35 [PATCH v3 0/6] Partial clone part 1: object filtering Jeff Hostetler
2017-11-07 19:35 ` [PATCH v3 1/6] dir: allow exclusions from blob in addition to file Jeff Hostetler
2017-11-07 19:35 ` [PATCH v3 2/6] oidmap: add oidmap iterator methods Jeff Hostetler
2017-11-07 19:35 ` [PATCH v3 3/6] oidset: add iterator methods to oidset Jeff Hostetler
2017-11-07 19:35 ` [PATCH v3 4/6] list-objects: filter objects in traverse_commit_list Jeff Hostetler
2017-11-07 23:20   ` Jonathan Tan
2017-11-08  5:01     ` Junio C Hamano
2017-11-16 17:28       ` Jeff Hostetler
2017-11-16 17:23     ` Jeff Hostetler
2017-11-07 19:35 ` [PATCH v3 5/6] rev-list: add list-objects filtering support Jeff Hostetler
2017-11-07 19:35 ` [PATCH v3 6/6] pack-objects: add list-objects filtering Jeff Hostetler
2017-11-08  0:45   ` Jonathan Tan [this message]
2017-11-08  5:25 ` [PATCH v3 0/6] Partial clone part 1: object filtering Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171107164519.eb49377ce11a6b31ab09bf83@google.com \
    --to=jonathantanmy@google.com \
    --cc=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).