From: Kevin Daudt <me@ikke.info>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Michael Haggerty <mhagger@alum.mit.edu>,
Thomas Gummerer <t.gummerer@gmail.com>
Subject: Re: [PATCH 1/3] notes: move hex_to_bytes() to hex.c and export it
Date: Sun, 5 Nov 2017 03:56:47 +0100 [thread overview]
Message-ID: <20171105025647.GB23275@alpha.vpn.ikke.info> (raw)
In-Reply-To: <508b1b3f-6b55-eee8-110a-c17d572ec27a@web.de>
On Tue, Oct 31, 2017 at 02:46:49PM +0100, René Scharfe wrote:
> Make the function for converting pairs of hexadecimal digits to binary
> available to other call sites.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> cache.h | 7 +++++++
> hex.c | 12 ++++++++++++
> notes.c | 17 -----------------
> 3 files changed, 19 insertions(+), 17 deletions(-)
>
> diff --git a/cache.h b/cache.h
> index 6440e2bf21..f06bfbaf32 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -1317,6 +1317,13 @@ extern int set_disambiguate_hint_config(const char *var, const char *value);
> extern int get_sha1_hex(const char *hex, unsigned char *sha1);
> extern int get_oid_hex(const char *hex, struct object_id *sha1);
>
> +/*
> + * Read `len` pairs of hexadecimal digits from `hex` and write the
> + * values to `binary` as `len` bytes. Return 0 on success, or -1 if
Is it correct to call the result binary? I would say that it's the value
that gets stored. To me, this value does not really have a base.
Kevin
next prev parent reply other threads:[~2017-11-05 2:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 13:46 [PATCH 1/3] notes: move hex_to_bytes() to hex.c and export it René Scharfe
2017-10-31 13:49 ` [PATCH 2/3] http-push: use hex_to_bytes() René Scharfe
2017-11-01 19:55 ` Jeff King
2017-11-01 21:59 ` René Scharfe
2017-11-01 22:15 ` Jeff King
2017-11-04 9:05 ` René Scharfe
2017-10-31 13:50 ` [PATCH 3/3] sha1_file: " René Scharfe
2017-11-01 19:58 ` Jeff King
2017-11-05 2:56 ` Kevin Daudt [this message]
2017-11-05 16:47 ` [PATCH 1/3] notes: move hex_to_bytes() to hex.c and export it René Scharfe
2017-11-05 19:57 ` Kevin Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171105025647.GB23275@alpha.vpn.ikke.info \
--to=me@ikke.info \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).