From: Simon Ruderich <simon@ruderich.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>,
"Ralf Thielow" <ralf.thielow@gmail.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/2] wrapper.c: consistently quote filenames in error messages
Date: Thu, 2 Nov 2017 11:20:31 +0100 [thread overview]
Message-ID: <20171102102031.v266n6nf6vftglu6@ruderich.org> (raw)
In-Reply-To: <xmqqlgjpqmyj.fsf@gitster.mtv.corp.google.com>
On Thu, Nov 02, 2017 at 02:16:52PM +0900, Junio C Hamano wrote:
> Junio C Hamano writes:
>> This patch is incomplete without adjusting a handful of tests to
>> expect the updated messages, no?
>
> I'll squash these in while queuing, but there might be more that I
> didn't notice.
Sorry, didn't think about the tests.
I've re-checked and I think those are the only affected tests.
The test suite passes with your squashed changes.
Regards
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
next prev parent reply other threads:[~2017-11-02 10:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 9:54 [PATCH 1/2] sequencer: factor out rewrite_file() René Scharfe
2017-10-31 9:58 ` [PATCH 2/2] sequencer: use O_TRUNC to truncate files René Scharfe
2017-10-31 16:34 ` Kevin Daudt
2017-11-01 15:34 ` Johannes Schindelin
2017-10-31 16:33 ` [PATCH 1/2] sequencer: factor out rewrite_file() Kevin Daudt
2017-11-01 6:06 ` Kevin Daudt
2017-11-01 11:10 ` Simon Ruderich
2017-11-01 13:00 ` René Scharfe
2017-11-01 14:44 ` [PATCH 1/2] wrapper.c: consistently quote filenames in error messages Simon Ruderich
2017-11-02 4:40 ` Junio C Hamano
2017-11-02 5:16 ` Junio C Hamano
2017-11-02 10:20 ` Simon Ruderich [this message]
2017-11-03 1:47 ` Junio C Hamano
2017-11-01 14:45 ` [PATCH 2/2] sequencer.c: check return value of close() in rewrite_file() Simon Ruderich
2017-11-01 17:09 ` René Scharfe
2017-11-01 15:33 ` [PATCH 1/2] sequencer: factor out rewrite_file() Johannes Schindelin
2017-11-01 19:47 ` Jeff King
2017-11-01 21:46 ` Johannes Schindelin
2017-11-01 22:16 ` Jeff King
2017-11-03 10:32 ` Simon Ruderich
2017-11-03 13:44 ` Junio C Hamano
2017-11-03 19:13 ` Jeff King
2017-11-04 9:05 ` René Scharfe
2017-11-04 9:35 ` Jeff King
2017-11-04 18:36 ` Simon Ruderich
2017-11-05 2:07 ` Jeff King
2017-11-06 16:13 ` Improved error handling (Was: [PATCH 1/2] sequencer: factor out rewrite_file()) Simon Ruderich
2017-11-16 10:36 ` Simon Ruderich
2017-11-17 22:33 ` Jeff King
2017-11-18 9:01 ` Johannes Sixt
2017-12-24 14:54 ` Jeff King
2017-12-24 15:45 ` Randall S. Becker
2017-12-25 10:28 ` Johannes Sixt
2017-11-03 14:46 ` [PATCH 1/2] sequencer: factor out rewrite_file() Johannes Schindelin
2017-11-03 18:57 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102102031.v266n6nf6vftglu6@ruderich.org \
--to=simon@ruderich.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=l.s.r@web.de \
--cc=ralf.thielow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).