From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Andrey Okoshkin <a.okoshkin@samsung.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
David Turner <dturner@twopensource.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] path: use xmalloc in add_to_trie
Date: Tue, 24 Oct 2017 12:26:59 -0700 [thread overview]
Message-ID: <20171024192658.4rvxvb34y64lt2tc@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kZM_hVi8BeTmL5u_QK5+=1g3gcPsccEe1AJVpDLUWz_9Q@mail.gmail.com>
On Tue, Oct 24, 2017 at 09:13:28AM -0700, Stefan Beller wrote:
> On Tue, Oct 24, 2017 at 8:15 AM, Andrey Okoshkin <a.okoshkin@samsung.com> wrote:
> > Add usage of xmalloc() instead of malloc() in add_to_trie() as xmalloc wraps
> > and checks memory allocation result.
> >
> > Signed-off-by: Andrey Okoshkin <a.okoshkin@samsung.com>
> > ---
> > Hello,
> > I'm not sure but it looks like there is a missing check of the malloc result.
> > memcpy() may crash with SIGSEGV due to the memory allocation failure.
> > make_trie_node() uses xmalloc() and xcalloc() - so I believe add_to_trie()
> > also should use it.
>
> Good catch! Thanks for spotting.
>
> Trying to find similar occurrences via git grep "= malloc" did not
> yield other places that need the same fix.
Don't forget realloc and calloc (though I don't think there are any
cases that need touching there; just a hint for anybody doing auditing).
-Peff
prev parent reply other threads:[~2017-10-24 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171024151508epcas2p4d9455e93e2e19bfb118b485d4ce14922@epcas2p4.samsung.com>
2017-10-24 15:15 ` [PATCH] path: use xmalloc in add_to_trie Andrey Okoshkin
2017-10-24 16:13 ` Stefan Beller
2017-10-24 19:26 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024192658.4rvxvb34y64lt2tc@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=a.okoshkin@samsung.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).