From: Jeff King <peff@peff.net>
To: Kevin Daudt <me@ikke.info>
Cc: 小川恭史 <aiueogawa217@gmail.com>, git@vger.kernel.org
Subject: Re: Can I remove multiple stashed states at a time?
Date: Sat, 14 Oct 2017 14:05:50 -0400 [thread overview]
Message-ID: <20171014180549.q35km6t44pkpwzdh@sigill.intra.peff.net> (raw)
In-Reply-To: <20171014150123.GA28038@alpha.vpn.ikke.info>
On Sat, Oct 14, 2017 at 05:01:23PM +0200, Kevin Daudt wrote:
> On Fri, Oct 13, 2017 at 01:35:22PM -0400, Jeff King wrote:
> > On Fri, Oct 13, 2017 at 11:58:12AM +0900, 小川恭史 wrote:
> >
> > You can also just do:
> >
> > for i in 1 2 3; do
> > git stash drop $i
> > done
> >
>
> Doesn't stash 2 become stash 1 after the first drop, and the same for 3,
> resulting in dropping stash 1, 3 and 5?
>
> So something like
>
> for i in 3 2 1; do
> git stash drop $i;
> done
>
> Or leave $i out altogether.
Oops, you're right.
For that matter, I didn't double check that a single "reflog delete"
handles this case correctly. That should be easy to test, though:
git init
echo base >file
git add file
git commit -m base
for i in $(seq 10); do
echo $i >file
git stash push -m $i
done
git reflog delete --updateref --rewrite refs/stash@{1} refs/stash@{2} refs/stash@{3}
That seems to leave:
$ git stash list
stash@{0}: On master: 10
stash@{1}: On master: 8
stash@{2}: On master: 6
stash@{3}: On master: 4
stash@{4}: On master: 3
stash@{5}: On master: 2
stash@{6}: On master: 1
which is not what we wanted (I'd guess also that it rewrites the reflog
3 times, negating any efficiency I claimed earlier).
-Peff
prev parent reply other threads:[~2017-10-14 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 2:58 Can I remove multiple stashed states at a time? 小川恭史
2017-10-13 17:35 ` Jeff King
2017-10-14 15:01 ` Kevin Daudt
2017-10-14 18:05 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171014180549.q35km6t44pkpwzdh@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=aiueogawa217@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ikke.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).