From: Jeff King <peff@peff.net>
To: Derrick Stolee <stolee@gmail.com>
Cc: Constantine <hi-angel@yandex.ru>,
Junio C Hamano <gitster@pobox.com>,
Christian Couder <christian.couder@gmail.com>,
Mike Hommey <mh@glandium.org>, git <git@vger.kernel.org>
Subject: Re: git-clone causes out of memory
Date: Fri, 13 Oct 2017 10:26:46 -0400 [thread overview]
Message-ID: <20171013142646.evapso5uxzvh2r2p@sigill.intra.peff.net> (raw)
In-Reply-To: <42cbcb4f-7f9d-df69-f55e-0ba42b931957@gmail.com>
On Fri, Oct 13, 2017 at 10:25:10AM -0400, Derrick Stolee wrote:
> This does appear to be the problem. The missing DIFF_OPT_HAS_CHANGES is
> causing diff_can_quit_early() to return false. Due to the corner-case of the
> bug it seems it will not be a huge performance improvement in most cases.
> Still worth fixing and I'm looking at your suggestions to try and learn this
> area better.
Yeah, I just timed some pathspec limits on linux.git, and it makes at
best a fraction of a percent improvement (but any improvement is well
within run-to-run noise). Which is not surprising.
I agree it's worth fixing, though.
-Peff
next prev parent reply other threads:[~2017-10-13 14:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 9:51 git-clone causes out of memory Constantine
2017-10-13 10:06 ` Mike Hommey
2017-10-13 10:26 ` Christian Couder
2017-10-13 10:37 ` Mike Hommey
2017-10-13 10:44 ` Christian Couder
2017-10-13 12:04 ` Junio C Hamano
2017-10-13 12:12 ` Constantine
2017-10-13 12:44 ` Jeff King
2017-10-13 13:15 ` Derrick Stolee
2017-10-13 13:39 ` Derrick Stolee
2017-10-13 13:50 ` Jeff King
2017-10-13 13:55 ` Derrick Stolee
2017-10-13 13:56 ` Jeff King
2017-10-13 14:10 ` Jeff King
2017-10-13 14:20 ` Jeff King
2017-10-13 14:25 ` Derrick Stolee
2017-10-13 14:26 ` Jeff King [this message]
2017-10-13 14:30 ` Derrick Stolee
2017-10-13 15:27 ` [PATCH] revision: quit pruning diff more quickly when possible Jeff King
2017-10-13 15:37 ` Derrick Stolee
2017-10-13 15:44 ` Jeff King
2017-10-14 2:43 ` Junio C Hamano
2017-10-13 12:35 ` git-clone causes out of memory Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013142646.evapso5uxzvh2r2p@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hi-angel@yandex.ru \
--cc=mh@glandium.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).