git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
* v2.15.0-rc1 test failure
@ 2017-10-11 22:15 Ramsay Jones
  2017-10-11 22:25 ` Ramsay Jones
  2017-10-11 22:34 ` Adam Dinwoodie
  0 siblings, 2 replies; 6+ messages in thread
From: Ramsay Jones @ 2017-10-11 22:15 UTC (permalink / raw)
  To: Adam Dinwoodie; +Cc: GIT Mailing-list

Hi Adam,

I had a test failure on the v2.15.0-rc1 build tonight.
The test in question being t0021-conversion.sh #15
('required process filter should filter data'). I didn't
have any test failures on v2.15.0-rc0, and I don't see
any change that would have affected this test.

Also, I ran this test by hand (well, in a shell loop) at
least 70 times tonight (after the test-suite run), without
any failures, so ... (unfortunately, I don't have a trash
directory to look at. :( )

I have just kicked off another full test-suite run.

Just a heads up! ;-)

ATB,
Ramsay Jones


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: v2.15.0-rc1 test failure
  2017-10-11 22:15 v2.15.0-rc1 test failure Ramsay Jones
@ 2017-10-11 22:25 ` Ramsay Jones
  2017-10-11 22:34 ` Adam Dinwoodie
  1 sibling, 0 replies; 6+ messages in thread
From: Ramsay Jones @ 2017-10-11 22:25 UTC (permalink / raw)
  To: Adam Dinwoodie; +Cc: GIT Mailing-list



On 11/10/17 23:15, Ramsay Jones wrote:
> Hi Adam,
> 
> I had a test failure on the v2.15.0-rc1 build tonight.
> The test in question being t0021-conversion.sh #15
> ('required process filter should filter data'). I didn't
> have any test failures on v2.15.0-rc0, and I don't see
> any change that would have affected this test.
> 
> Also, I ran this test by hand (well, in a shell loop) at
> least 70 times tonight (after the test-suite run), without
> any failures, so ... (unfortunately, I don't have a trash
> directory to look at. :( )
> 
> I have just kicked off another full test-suite run.
> 
> Just a heads up! ;-)

Oops, for mailing list reader, I should have made clear that
this failure is only on cygwin. :-D

ATB,
Ramsay Jones



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: v2.15.0-rc1 test failure
  2017-10-11 22:15 v2.15.0-rc1 test failure Ramsay Jones
  2017-10-11 22:25 ` Ramsay Jones
@ 2017-10-11 22:34 ` Adam Dinwoodie
  2017-10-11 23:08   ` Jonathan Nieder
  2017-10-12  0:27   ` Ramsay Jones
  1 sibling, 2 replies; 6+ messages in thread
From: Adam Dinwoodie @ 2017-10-11 22:34 UTC (permalink / raw)
  To: Ramsay Jones; +Cc: GIT Mailing-list

On Wed, Oct 11, 2017 at 11:15:57PM +0100, Ramsay Jones wrote:
> Hi Adam,
> 
> I had a test failure on the v2.15.0-rc1 build tonight.
> The test in question being t0021-conversion.sh #15
> ('required process filter should filter data'). I didn't
> have any test failures on v2.15.0-rc0, and I don't see
> any change that would have affected this test.
> 
> Also, I ran this test by hand (well, in a shell loop) at
> least 70 times tonight (after the test-suite run), without
> any failures, so ... (unfortunately, I don't have a trash
> directory to look at. :( )
> 
> I have just kicked off another full test-suite run.
> 
> Just a heads up! ;-)

Hi Ramsay,

I assume, given you're emailing me, that this is a Cygwin failure?

t0021.15 has PERL as a requirement, and I see semi-regular failures from
Git tests that are Perl-based in one way or another (git-svn tests are
the most common problems).  I've not spotted t0021 failing in that way,
but it sounds like the same class of problem.

I dig into these failures when I see them, mostly by running the script
a few hundred times until I get the failure again, and they've always
been Perl itself segfaulting.  That points to the problem being in
Cygwin's Perl package rather than Git, and it's very unlikely to be
anything that's got worse in v2.15.0.

I've never managed to get further than pinning the blame on Perl,
though.  If you manage to reproduce the failure and it turns out to be
something different, or you manage to dig into the failure in Perl
itself, that'd be some very interesting news.

Adam

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: v2.15.0-rc1 test failure
  2017-10-11 22:34 ` Adam Dinwoodie
@ 2017-10-11 23:08   ` Jonathan Nieder
  2017-10-12  0:27   ` Ramsay Jones
  1 sibling, 0 replies; 6+ messages in thread
From: Jonathan Nieder @ 2017-10-11 23:08 UTC (permalink / raw)
  To: Adam Dinwoodie; +Cc: Ramsay Jones, GIT Mailing-list

Hi,

Adam Dinwoodie wrote:

> t0021.15 has PERL as a requirement, and I see semi-regular failures from
> Git tests that are Perl-based in one way or another (git-svn tests are
> the most common problems).  I've not spotted t0021 failing in that way,
> but it sounds like the same class of problem.
>
> I dig into these failures when I see them, mostly by running the script
> a few hundred times until I get the failure again, and they've always
> been Perl itself segfaulting.  That points to the problem being in
> Cygwin's Perl package rather than Git, and it's very unlikely to be
> anything that's got worse in v2.15.0.

That reminds me of https://bugs.debian.org/868738, which I tracked down
to perl's "die" helper using errno to determine the exit status instead
of deterministically using 128.  I wasn't able to track it down further
than that.

t/t0021/rot13-filter.pl doesn't have any similar suspect constructs, but
thought I should mention it anyway.

Thanks,
Jonathan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: v2.15.0-rc1 test failure
  2017-10-11 22:34 ` Adam Dinwoodie
  2017-10-11 23:08   ` Jonathan Nieder
@ 2017-10-12  0:27   ` Ramsay Jones
  2017-10-12  9:06     ` Adam Dinwoodie
  1 sibling, 1 reply; 6+ messages in thread
From: Ramsay Jones @ 2017-10-12  0:27 UTC (permalink / raw)
  To: Adam Dinwoodie; +Cc: GIT Mailing-list



On 11/10/17 23:34, Adam Dinwoodie wrote:
[snip]
> Hi Ramsay,
> 
> I assume, given you're emailing me, that this is a Cygwin failure?

Yes, sorry, I should have made that clear.

> t0021.15 has PERL as a requirement, and I see semi-regular failures from
> Git tests that are Perl-based in one way or another (git-svn tests are
> the most common problems).  I've not spotted t0021 failing in that way,
> but it sounds like the same class of problem.

Yep, many moons ago, I used to run the svn tests (on Linux and cygwin)
which would fail intermittently on cygwin. I didn't notice any problem
with perl though.

> I dig into these failures when I see them, mostly by running the script
> a few hundred times until I get the failure again, and they've always
> been Perl itself segfaulting.  That points to the problem being in
> Cygwin's Perl package rather than Git, and it's very unlikely to be
> anything that's got worse in v2.15.0.

Since I stopped running the svn tests, the number of intermittent test failures on cygwin have dropped significantly, but haven't gone away
completely.

I just finished the second test-suite run and, of course, t0021 ran
without problem this time. Hmm, I don't think I have time to chase
this down at the moment. I will keep your 'perl hypothesis' in mind
for next time, however.

Thanks.

ATB,
Ramsay Jones



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: v2.15.0-rc1 test failure
  2017-10-12  0:27   ` Ramsay Jones
@ 2017-10-12  9:06     ` Adam Dinwoodie
  0 siblings, 0 replies; 6+ messages in thread
From: Adam Dinwoodie @ 2017-10-12  9:06 UTC (permalink / raw)
  To: Ramsay Jones; +Cc: GIT Mailing-list

On Thu, Oct 12, 2017 at 01:27:57AM +0100, Ramsay Jones wrote:
> On 11/10/17 23:34, Adam Dinwoodie wrote:
> [snip]
> > Hi Ramsay,
> > 
> > I assume, given you're emailing me, that this is a Cygwin failure?
> 
> Yes, sorry, I should have made that clear.
> 
> > t0021.15 has PERL as a requirement, and I see semi-regular failures from
> > Git tests that are Perl-based in one way or another (git-svn tests are
> > the most common problems).  I've not spotted t0021 failing in that way,
> > but it sounds like the same class of problem.
> 
> Yep, many moons ago, I used to run the svn tests (on Linux and cygwin)
> which would fail intermittently on cygwin. I didn't notice any problem
> with perl though.
> 
> > I dig into these failures when I see them, mostly by running the script
> > a few hundred times until I get the failure again, and they've always
> > been Perl itself segfaulting.  That points to the problem being in
> > Cygwin's Perl package rather than Git, and it's very unlikely to be
> > anything that's got worse in v2.15.0.
> 
> Since I stopped running the svn tests, the number of intermittent test failures on cygwin have dropped significantly, but haven't gone away
> completely.
> 
> I just finished the second test-suite run and, of course, t0021 ran
> without problem this time. Hmm, I don't think I have time to chase
> this down at the moment. I will keep your 'perl hypothesis' in mind
> for next time, however.

Evidence for my Perl hypothesis, which I offer at least as much so other
people can check my logic as anything else:

Here's a fairly typical set of verbose output from a test failing in
this way [0].  The critical bit is the line "error: git-svn died of
signal 11".  Since git-svn is a Perl script, and Perl is the sort of
interpreted language that would throw its own errors if it encountered a
script bug, the fact that it's hitting a segfault means there's a
problem of some ilk with the Perl interpreter itself.

[0]: https://github.com/me-and/Cygwin-Git/issues/13#issuecomment-211372448

Adam

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 22:15 v2.15.0-rc1 test failure Ramsay Jones
2017-10-11 22:25 ` Ramsay Jones
2017-10-11 22:34 ` Adam Dinwoodie
2017-10-11 23:08   ` Jonathan Nieder
2017-10-12  0:27   ` Ramsay Jones
2017-10-12  9:06     ` Adam Dinwoodie

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox