From: Kevin Daudt <firstname.lastname@example.org> To: "Robert P. J. Day" <email@example.com> Cc: Junio C Hamano <firstname.lastname@example.org>, Paul Smith <email@example.com>, Git Mailing list <firstname.lastname@example.org> Subject: Re: "git rm" seems to do recursive removal even without "-r" Date: Sun, 8 Oct 2017 13:37:32 +0200 Message-ID: <20171008113732.GA8251@alpha.vpn.ikke.info> (raw) In-Reply-To: <alpine.LFD.email@example.com> On Sun, Oct 08, 2017 at 05:07:12AM -0400, Robert P. J. Day wrote: > On Sun, 8 Oct 2017, Junio C Hamano wrote: > > > "Robert P. J. Day" <firstname.lastname@example.org> writes: > > > > > ... so if, in the kernel source > > > tree, i ran: > > > > > > $ git rm \*.c > > > > > > i would end up removing *all* 25,569 "*.c" files in the kernel source > > > repository. > > > > Yes, as that is exactly what the command line asks Git to do. > > so if i wanted git to remove, say, all files named "Makefile*" from > everywhere in the linux kernel source tree, the (dry run) command > would be: > > $ git rm -n Makefile\* > > is that it? let's try that: > > $ git rm -n Makefile\* > rm 'Makefile' > $ > > oops. > > rday > So your question is not su much about the recursive option (delete mentioned directories, including their contents), but globbing (expanding the * to any files matching the pattern). The explanation of <files> mentions this: Files to remove. Fileglobs (e.g. *.c) can be given to remove all matching files. This indicates that git itself (not your shell alone) does file globbing. I think the confusing part is that most people have no clear idea of the separation between what the shell sees and interprets, and what the program actually gets. When you execute: $ git rm Makefile\* What git actually sees is this: Makefile* The shell intepreted the \* to mean just '*' and not interpret it itself, and provide that to the executed program. Git, in its turn, would start matching any file to that pattern to see which files matches. If you would execute: $ git rm 'Makefile\*' Git would see: Makefile\* Which does the thing you intended. So you have to deal with 2 levels of programs interpreting the arguments, not just one. Whether '*.c' should match just all .c files in the current dir, or all files ending with .c depends on whether the path seperator is matched by * or not and is a separate discussion. GITGLOSSARY(7) under pathspec mentions this: glob Git treats the pattern as a shell glob suitable for consumption by fnmatch(3) with the FNM_PATHNAME flag: wildcards in the pattern will not match a / in the pathname. So that seems to indicate '*.c' should only match .c files in the current dir. I'm not sure why that's not the case. I hope this clears up what's happening a bit, and perhaps can lead to improvements to the documentation so that it's not so surprising. Kind regards, Kevin.
next prev parent reply index Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-07 18:39 Robert P. J. Day 2017-10-07 19:04 ` Todd Zullinger 2017-10-07 19:12 ` Robert P. J. Day 2017-10-07 19:29 ` Jeff King 2017-10-07 19:32 ` Robert P. J. Day 2017-10-07 19:38 ` Jeff King 2017-10-07 19:43 ` Robert P. J. Day 2017-10-07 21:05 ` Theodore Ts'o 2017-10-07 21:40 ` Robert P. J. Day 2017-10-07 21:44 ` Paul Smith 2017-10-07 21:55 ` Robert P. J. Day 2017-10-08 4:20 ` Junio C Hamano 2017-10-08 9:07 ` Robert P. J. Day 2017-10-08 11:37 ` Kevin Daudt [this message] 2017-10-08 11:56 ` Robert P. J. Day 2017-10-08 12:23 ` Martin Ågren 2017-10-08 12:39 ` René Scharfe 2017-10-08 12:45 ` Robert P. J. Day 2017-10-10 11:52 ` Heiko Voigt 2017-10-11 8:31 ` Robert P. J. Day 2017-10-08 14:32 ` Paul Smith 2017-10-08 18:40 ` Theodore Ts'o 2017-10-08 19:44 ` Robert P. J. Day 2017-10-08 20:42 ` Theodore Ts'o 2017-10-09 17:52 ` Jeff King 2017-10-10 8:36 ` Robert P. J. Day 2017-10-10 8:58 ` Junio C Hamano 2017-10-10 12:19 ` Paul Smith 2017-10-10 19:44 ` Robert P. J. Day
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171008113732.GA8251@alpha.vpn.ikke.info \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
firstname.lastname@example.org mailing list mirror (one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ or Tor2web: https://www.tor2web.org/ AGPL code for this site: git clone https://public-inbox.org/ public-inbox