From: lars.schneider@autodesk.com
To: git@vger.kernel.org
Cc: peff@peff.net, t.gummerer@gmail.com, jrnieder@gmail.com,
gitster@pobox.com, Lars Schneider <larsxschneider@gmail.com>
Subject: [PATCH v1 0/2] fix temporary garbage in the cache entry
Date: Thu, 5 Oct 2017 12:44:05 +0200 [thread overview]
Message-ID: <20171005104407.65948-1-lars.schneider@autodesk.com> (raw)
From: Lars Schneider <larsxschneider@gmail.com>
Hi,
in [1] Peff noticed that the delayed filter mechanism causes garbage
in the cache entry for a brief moment during a delayed checkout process.
The first patch fixes this issue. The second patch ensures that we don't
write garbage in that way to the cache entry caused by any other unknown
or external reason ever again.
Please review carefully in case I overlooked some unintended side
effect.
Thank you,
Lars
[1] https://public-inbox.org/git/20171005034632.kzsspk7wsuk23kf2@sigill.intra.peff.net/
Base Ref: v2.15.0-rc0
Web-Diff: https://github.com/larsxschneider/git/commit/d6fff1a941
Checkout: git fetch https://github.com/larsxschneider/git filter-process/fix-cache-entry-v1 && git checkout d6fff1a941
Lars Schneider (2):
entry.c: update cache entry only for existing files
entry.c: check if file exists after checkout
entry.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
base-commit: 217f2767cbcb562872437eed4dec62e00846d90c
--
2.14.2
next reply other threads:[~2017-10-05 10:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 10:44 lars.schneider [this message]
2017-10-05 10:44 ` [PATCH v1 1/2] entry.c: update cache entry only for existing files lars.schneider
2017-10-05 11:12 ` Jeff King
2017-10-05 11:19 ` Junio C Hamano
2017-10-05 11:26 ` Jeff King
2017-10-05 23:01 ` Junio C Hamano
2017-10-06 4:54 ` Jeff King
2017-10-08 21:37 ` Lars Schneider
2017-10-09 17:47 ` Jeff King
2017-10-09 17:48 ` [PATCH 1/3] write_entry: fix leak when retrying delayed filter Jeff King
2017-10-10 0:00 ` Junio C Hamano
2017-10-10 9:23 ` Simon Ruderich
2017-10-10 9:25 ` Jeff King
2017-10-10 9:49 ` Simon Ruderich
2017-10-09 17:48 ` [PATCH 2/3] write_entry: avoid reading blobs in CE_RETRY case Jeff King
2017-10-10 0:00 ` Junio C Hamano
2017-10-09 17:50 ` [PATCH 3/3] write_entry: untangle symlink and regular-file cases Jeff King
2017-10-10 0:03 ` Junio C Hamano
2017-10-05 10:44 ` [PATCH v1 2/2] entry.c: check if file exists after checkout lars.schneider
2017-10-05 11:23 ` Jeff King
2017-10-06 4:26 ` Junio C Hamano
2017-10-06 4:56 ` Jeff King
2017-10-06 6:03 ` Junio C Hamano
2017-10-06 6:05 ` Jeff King
2017-10-06 7:58 ` Junio C Hamano
2017-10-08 21:41 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005104407.65948-1-lars.schneider@autodesk.com \
--to=lars.schneider@autodesk.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).