From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] commit: use strbuf_add() to add a buffer to a strbuf
Date: Mon, 2 Oct 2017 01:18:56 -0400 [thread overview]
Message-ID: <20171002051855.f3g2sz32ysjd6xu4@sigill.intra.peff.net> (raw)
In-Reply-To: <223ef0c8-dac2-747b-41c8-3bad62f4c274@web.de>
On Sun, Oct 01, 2017 at 04:54:14PM +0200, René Scharfe wrote:
> This is shorter, easier and makes the intent clearer.
>
> Patch generated with Coccinelle and contrib/coccinelle/strbuf.cocci.
Technically this behaves differently if there is a NUL embedded in the
string. I'd expect that to be unlikely in most cases. And when it is
possible, I'd venture to say that the new behavior is likely to be the
correct one.
This case is fine (and any embedded NUL would be cut off by setenv
anyway). As a general transformation, this is not as obviously safe as
many of the others. But since we eyeball the output of coccinelle
anyway, it should be fine (and any code which is _relying_ on that
behavior really ought to be rewritten in a less subtle way).
-Peff
prev parent reply other threads:[~2017-10-02 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-01 14:49 [PATCH 1/2] coccinelle: add rules to use strbuf_add() for adding buffers to strbufs René Scharfe
2017-10-01 14:54 ` [PATCH 2/2] commit: use strbuf_add() to add a buffer to a strbuf René Scharfe
2017-10-02 5:18 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002051855.f3g2sz32ysjd6xu4@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).