From: Han-Wen Nienhuys <hanwen@google.com>
To: git@vger.kernel.org
Cc: peff@peff.net, bmwill@google.com, Han-Wen Nienhuys <hanwen@google.com>
Subject: [PATCH 2/3] read_gitfile_gently: clarify return value ownership.
Date: Tue, 26 Sep 2017 13:21:49 +0200 [thread overview]
Message-ID: <20170926112150.21850-3-hanwen@google.com> (raw)
In-Reply-To: <20170926112150.21850-1-hanwen@google.com>
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
setup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/setup.c b/setup.c
index 42400fcc5..8c95841d5 100644
--- a/setup.c
+++ b/setup.c
@@ -541,7 +541,8 @@ void read_gitfile_error_die(int error_code, const char *path, const char *dir)
/*
* Try to read the location of the git directory from the .git file,
- * return path to git directory if found.
+ * return path to git directory if found. The return value comes from
+ * a shared buffer.
*
* On failure, if return_error_code is not NULL, return_error_code
* will be set to an error code and NULL will be returned. If
--
2.14.1.821.g8fa685d3b7-goog
next prev parent reply other threads:[~2017-09-26 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 11:21 [PATCH 0/3] Comment fixes Han-Wen Nienhuys
2017-09-26 11:21 ` [PATCH 1/3] real_path: clarify return value ownership Han-Wen Nienhuys
2017-09-26 11:21 ` Han-Wen Nienhuys [this message]
2017-09-26 11:21 ` [PATCH 3/3] string-list.h: move documentation from Documentation/api/ into header Han-Wen Nienhuys
2017-09-27 0:13 ` [PATCH 0/3] Comment fixes Junio C Hamano
2017-10-02 23:50 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926112150.21850-3-hanwen@google.com \
--to=hanwen@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).