From: Jeff King <peff@peff.net>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] git: add --no-optional-locks option
Date: Fri, 22 Sep 2017 11:04:38 -0400 [thread overview]
Message-ID: <20170922150438.whslnn4qkamdhewr@sigill.intra.peff.net> (raw)
In-Reply-To: <dcd542e9-ba92-4dc8-6929-2d0f02bd6307@jeffhostetler.com>
On Fri, Sep 22, 2017 at 07:22:28AM -0400, Jeff Hostetler wrote:
> > > I don't think we should pass this environment variable to remote
> > > repositories. It should be listed in local_repo_env[] in environment.c.
> >
> > I'm not sure I agree. This is really about the context in which the
> > command is executing, not anything about the particular repository
> > you're operating on.
> >
> > For fetch/push operations that touch a remote, I doubt it would matter
> > either way (and anyway, those often cross network boundaries that don't
> > propagate environment variables anyway).
> >
> > But imagine that "git status" learns to recurse into submodules and run
> > "git status" inside them. Surely we would want the submodule repos to
> > also avoid taking any unnecessary locks?
> >
> > -Peff
> >
>
> https://github.com/git-for-windows/git/commit/ff63b51c22389139a864eb2e565c6cdc5a30f061
>
> https://github.com/git-for-windows/git/pull/1004/commits/45bad66192352481acbc826f11d90c8928b39a7a
>
> We should compare this with what we did in Git for Windows last fall.
> I guess those commits didn't get pushed upstream.
Right. I think you missed the initial message in the thread that
explains how this is an expanded version of ff63b51c22. :)
I didn't know about the environment thing in 45bad66192, though[1]. That
makes me even more confident that this is the right approach.
-Peff
[1] Sorry for not doing my homework more carefully on the existing
solution. GitHub Desktop ran into the same situation and pointed me
at ff63b51c22. I extrapolated the rest of it on my own. ;)
next prev parent reply other threads:[~2017-09-22 15:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 4:32 [PATCH] git: add --no-optional-locks option Jeff King
2017-09-21 4:55 ` Junio C Hamano
2017-09-21 5:08 ` Jeff King
2017-09-21 5:29 ` Junio C Hamano
2017-09-21 18:25 ` Johannes Sixt
2017-09-22 4:25 ` Jeff King
2017-09-22 11:22 ` Jeff Hostetler
2017-09-22 15:04 ` Jeff King [this message]
2017-09-22 20:09 ` Stefan Beller
2017-09-22 21:25 ` Jeff King
2017-09-22 21:41 ` Stefan Beller
2017-09-23 3:34 ` Jeff King
2017-09-25 18:51 ` Stefan Beller
2017-09-27 6:44 ` Jeff King
2017-09-22 6:42 ` Daniel Santos
2017-09-22 16:04 ` Jeff King
2017-09-24 11:31 ` Kaartic Sivaraam
2017-09-25 16:17 ` Johannes Schindelin
2017-09-26 14:44 ` Jeff Hostetler
2017-09-25 16:10 ` Johannes Schindelin
2017-09-25 17:00 ` Jeff King
[not found] ` <79ed4c34-1727-7c1e-868a-1206902638ad@gmail.com>
2017-09-27 6:40 ` Jeff King
2017-09-27 13:50 ` Kaartic Sivaraam
2017-09-27 16:28 ` Jeff King
2017-09-27 6:54 ` [PATCH v2] " Jeff King
2017-09-28 16:15 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922150438.whslnn4qkamdhewr@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).