From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 2/4] commit-slab.h: avoid -Wsign-compare warnings
Date: Fri, 22 Sep 2017 01:29:16 -0400 [thread overview]
Message-ID: <20170922052916.fiafkbykroenq65n@sigill.intra.peff.net> (raw)
In-Reply-To: <f120046a-f0b3-6199-a2fc-65a5fd37c0a3@ramsayjones.plus.com>
On Thu, Sep 21, 2017 at 05:47:36PM +0100, Ramsay Jones wrote:
> diff --git a/commit-slab.h b/commit-slab.h
> index 333d81e37..dcaab8ca0 100644
> --- a/commit-slab.h
> +++ b/commit-slab.h
> @@ -78,7 +78,7 @@ static MAYBE_UNUSED void init_ ##slabname(struct slabname *s) \
> \
> static MAYBE_UNUSED void clear_ ##slabname(struct slabname *s) \
> { \
> - int i; \
> + unsigned int i; \
> for (i = 0; i < s->slab_count; i++) \
> free(s->slab[i]); \
> s->slab_count = 0; \
> @@ -89,13 +89,13 @@ static MAYBE_UNUSED elemtype *slabname## _at_peek(struct slabname *s, \
> const struct commit *c, \
> int add_if_missing) \
> { \
> - int nth_slab, nth_slot; \
> + unsigned int nth_slab, nth_slot; \
I have a feeling that in the long run these should all be size_t, but
it's probably pretty unlikely to overflow in practice. At any rate, the
slab index itself is an unsigned, so it probably makes sense to match
that for now.
-Peff
next prev parent reply other threads:[~2017-09-22 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 16:47 [PATCH 2/4] commit-slab.h: avoid -Wsign-compare warnings Ramsay Jones
2017-09-22 5:29 ` Jeff King [this message]
2017-09-22 15:46 ` Ramsay Jones
2017-09-22 15:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922052916.fiafkbykroenq65n@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).