From: Jeff King <peff@peff.net>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Stephan Beyer <s-beyer@gmx.net>
Subject: Re: [PATCH] diff-lib: clear `pending` object-array in `index_differs_from()`
Date: Thu, 21 Sep 2017 00:52:00 -0400 [thread overview]
Message-ID: <20170921045200.bw2yezcwmlxvemwn@sigill.intra.peff.net> (raw)
In-Reply-To: <CAN0heSqVxBreaZN9x1XtX2OpeAoVZNzixr+vzyCWwe8UKtdtgQ@mail.gmail.com>
On Thu, Sep 21, 2017 at 05:56:21AM +0200, Martin Ågren wrote:
> > Looks good. A similar bug was the exact reason for adding the function
> > in 46be82312. I did a grep for 'free.*\.objects' to see if there were
> > other cases.
>
> Ah. I grepped for "pending.objects", but didn't go more general than that.
I did at first, too. My optimism lessened when I ran the more general
grep. :)
> > As I suspect you're working your way through leak-checker results, I'm
> > OK if you want to punt on digging into more cases for now and just fix
> > ones that the tool has identified as real leaks.
>
> I am indeed going through ASan results. Your UNLEAK helps immensely!
> (I'm collecting UNLEAKs on the side. I see now that UNLEAK is in master,
> so I should probably submit those where I believe things are
> "UNLEAK-complete".)
Thanks! That's exactly what I'd hoped might happen when I started on
UNLEAK.
-Peff
next prev parent reply other threads:[~2017-09-21 4:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 19:47 [PATCH] diff-lib: clear `pending` object-array in `index_differs_from()` Martin Ågren
2017-09-20 20:02 ` Jeff King
2017-09-21 3:56 ` Martin Ågren
2017-09-21 4:52 ` Jeff King [this message]
2017-09-22 23:34 ` [PATCH v2 0/6] reroll ma/plugleaks; more `object_array`-fixes Martin Ågren
2017-09-22 23:34 ` [PATCH v2 1/6] builtin/commit: fix memory leak in `prepare_index()` Martin Ågren
2017-09-22 23:34 ` [PATCH v2 2/6] commit: fix memory leak in `reduce_heads()` Martin Ågren
2017-09-22 23:34 ` [PATCH v2 3/6] leak_pending: use `object_array_clear()`, not `free()` Martin Ågren
2017-09-23 3:47 ` Jeff King
2017-09-22 23:34 ` [PATCH v2 4/6] object_array: " Martin Ågren
2017-09-23 4:04 ` Jeff King
2017-09-23 9:41 ` Martin Ågren
2017-09-22 23:34 ` [PATCH v2 5/6] object_array: add and use `object_array_pop()` Martin Ågren
2017-09-23 4:27 ` Jeff King
2017-09-23 9:49 ` Martin Ågren
2017-09-23 15:47 ` Jeff King
2017-09-22 23:34 ` [PATCH v2 6/6] pack-bitmap[-write]: use `object_array_clear()`, don't leak Martin Ågren
2017-09-23 4:35 ` Jeff King
2017-09-23 4:37 ` [PATCH v2 0/6] reroll ma/plugleaks; more `object_array`-fixes Jeff King
2017-09-23 9:54 ` Martin Ågren
2017-09-23 16:13 ` Jeff King
2017-09-23 16:38 ` Jeff King
2017-09-24 19:59 ` Martin Ågren
2017-09-25 16:08 ` Jeff King
2017-10-01 15:04 ` Martin Ågren
2017-09-24 7:01 ` Junio C Hamano
2017-09-24 20:00 ` Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921045200.bw2yezcwmlxvemwn@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).