From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] revision: replace "struct cmdline_pathspec" with argv_array
Date: Thu, 21 Sep 2017 00:50:14 -0400 [thread overview]
Message-ID: <20170921045014.yuln2edqybwusyrk@sigill.intra.peff.net> (raw)
In-Reply-To: <20170921044112.GB91069@aiede.mtv.corp.google.com>
On Wed, Sep 20, 2017 at 09:41:12PM -0700, Jonathan Nieder wrote:
> > Well, no...the idea is that this is a function which leaks a bunch of
> > memory, and we shouldn't have to think hard about how often its leak can
> > be triggered or how severe it is. We should just fix it.
>
> I forgot to say: thanks for writing such a pleasant patch.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
You're welcome. :)
> Here's such a patch.
>
> -- 8< --
> Subject: pathspec doc: parse_pathspec does not maintain references to args
> [...]
Yay!
This looks great to me. I think the whole pathspec API could use better
documentation, but this is certainly a good start.
-Peff
next prev parent reply other threads:[~2017-09-21 4:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 19:47 [PATCH] revision: fix memory leaks with `struct cmdline_pathspec` Martin Ågren
2017-09-20 20:25 ` Jeff King
2017-09-20 20:36 ` [PATCH] revision: replace "struct cmdline_pathspec" with argv_array Jeff King
2017-09-20 22:48 ` Jonathan Nieder
2017-09-21 3:04 ` Jeff King
2017-09-21 3:49 ` Jonathan Nieder
2017-09-21 4:48 ` Jeff King
2017-09-21 4:41 ` Jonathan Nieder
2017-09-21 4:50 ` Jeff King [this message]
2017-09-21 5:10 ` Junio C Hamano
2017-09-21 3:57 ` Martin Ågren
2017-09-21 4:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921045014.yuln2edqybwusyrk@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).