From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Ben Peart <Ben.Peart@microsoft.com>,
Junio C Hamano <gitster@pobox.com>, Karsten Blees <blees@dcon.de>
Subject: Re: [PATCH] Win32: simplify loading of DLL functions
Date: Wed, 20 Sep 2017 14:23:10 -0700 [thread overview]
Message-ID: <20170920212310.GF27425@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1.1709202235300.219280@virtualbox>
Johannes Schindelin wrote:
> On Tue, 19 Sep 2017, Jonathan Nieder wrote:
>> Could this example go near the top of the header instead? That way,
>> it's easier for people reading the header to see how to use it.
>
> Funny, I am *so* used to examples being at the very end, from tutorials to
> man pages.
>
> If my experience is any indication, I would rather keep this order.
Sorry for the lack of clarity. I meant "near the top of the header
*file*".
[...]
>> Are any of the Git for Windows users something that could go upstream
>> along with this patch? That would help illustrate what a good caller
>> looks like, which should help with reviewing future patches that use
>> this code.
>
> I do not currently have the time to do that, that's why I did not
> accompany the patch by any user.
>
> However, having said that, Ben's patch series will make for an *excellent*
> user, fulfilling your wish.
Ok. I think what you are saying is "go ahead --- anyone is welcome to
grab some patches from git for windows and upstream them", which is a
perfectly reasonable answer.
[...]
>> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Okay, I'll add that for v2. Will wait a couple of days in case more stuff
> crops up.
FWIW nothing I noticed came to the level of requiring a v2 imho. If any
of the ideas I mentioned seems good, they can go in patches on top.
The patch is in Junio's jch branch and I wouldn't be surprised if it
hits "next" soon.
Thanks again,
Jonathan
next prev parent reply other threads:[~2017-09-20 21:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 15:24 [PATCH] Win32: simplify loading of DLL functions Johannes Schindelin
2017-09-19 18:07 ` Jonathan Nieder
2017-09-20 4:44 ` Junio C Hamano
2017-09-20 21:16 ` Johannes Schindelin
2017-09-20 21:23 ` Jonathan Nieder [this message]
2017-09-21 6:18 ` Junio C Hamano
2017-09-25 16:06 ` [PATCH v2 0/1] Simplify loading of DLL functions on Windows Johannes Schindelin
2017-09-25 16:06 ` [PATCH v2 1/1] Win32: simplify loading of DLL functions Johannes Schindelin
2017-09-25 16:52 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920212310.GF27425@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=Ben.Peart@microsoft.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=blees@dcon.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).