From: Jeff King <peff@peff.net>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] commit: fix memory leak in `reduce_heads()`
Date: Wed, 20 Sep 2017 16:15:32 -0400 [thread overview]
Message-ID: <20170920201532.paynyzq7ln7cadqc@sigill.intra.peff.net> (raw)
In-Reply-To: <1505936846-2195-3-git-send-email-martin.agren@gmail.com>
On Wed, Sep 20, 2017 at 09:47:25PM +0200, Martin Ågren wrote:
> We don't free the temporary scratch space we use with
> `remove_redundant()`. Free it similar to how we do it in
> `get_merge_bases_many_0()`.
Yep, seems very straightforward, and there are no code paths where we
wouldn't want this.
-Peff
next prev parent reply other threads:[~2017-09-20 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 19:47 [PATCH] commit: fix memory leak in `reduce_heads()` Martin Ågren
2017-09-20 20:15 ` Jeff King [this message]
2017-09-20 21:34 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920201532.paynyzq7ln7cadqc@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).