From: Brandon Williams <bmwill@google.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] protocol: make parse_protocol_version() private
Date: Mon, 18 Sep 2017 09:38:10 -0700 [thread overview]
Message-ID: <20170918163810.GA144331@google.com> (raw)
In-Reply-To: <1cb7d40d-3f11-71a0-6e53-dced7810a0ca@ramsayjones.plus.com>
On 09/17, Ramsay Jones wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Brandon,
>
> If you need to re-roll your 'bw/protocol-v1' branch, could you please
> squash this into the relevant patch (commit 45954f179e, "protocol:
> introduce protocol extention mechanisms", 13-09-2017).
>
> This assumes you agree that this symbol does not need to be public; if
> not, then please just ignore! ;-)
Thanks! I've updated my local version of the series to reflect this.
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> protocol.c | 2 +-
> protocol.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/protocol.c b/protocol.c
> index 1b16c7b9a..369503065 100644
> --- a/protocol.c
> +++ b/protocol.c
> @@ -2,7 +2,7 @@
> #include "config.h"
> #include "protocol.h"
>
> -enum protocol_version parse_protocol_version(const char *value)
> +static enum protocol_version parse_protocol_version(const char *value)
> {
> if (!strcmp(value, "0"))
> return protocol_v0;
> diff --git a/protocol.h b/protocol.h
> index 2fa6486d0..18f9a5235 100644
> --- a/protocol.h
> +++ b/protocol.h
> @@ -7,7 +7,6 @@ enum protocol_version {
> protocol_v1 = 1,
> };
>
> -extern enum protocol_version parse_protocol_version(const char *value);
> extern enum protocol_version get_protocol_version_config(void);
> extern enum protocol_version determine_protocol_version_server(void);
> extern enum protocol_version determine_protocol_version_client(const char *server_response);
> --
> 2.14.0
--
Brandon Williams
prev parent reply other threads:[~2017-09-18 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 16:53 [PATCH] protocol: make parse_protocol_version() private Ramsay Jones
2017-09-18 16:38 ` Brandon Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918163810.GA144331@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).