From: Derrick Stolee <dstolee@microsoft.com>
To: git@vger.kernel.org
Cc: johannes.schindelin@gmx.de, git@jeffhostetler.com,
kewillf@microsoft.com, Derrick Stolee <dstolee@microsoft.com>
Subject: [PATCH 1/3] sha1_name: Create perf test for find_unique_abbrev()
Date: Fri, 15 Sep 2017 12:57:48 -0400 [thread overview]
Message-ID: <20170915165750.198201-2-dstolee@microsoft.com> (raw)
In-Reply-To: <20170915165750.198201-1-dstolee@microsoft.com>
Create helper program test-abbrev to compute the minimum length of a
disambiguating short-sha for 100,000 object ids. The ids are created
by iterating an unsigned int hash_base by a constant hash_delta and
copying hash_base five times across the sha1. Iterating by hash_delta
does not create a duplicate value for over 10,000,000 iterations.
test-abberv demonstrates the performance improvements that will be
shown by later improvements to the find_unique_abberv(). The value of
100,000 is large enough to show the significance of the later
improvements while only taking a few seconds on large repos.
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
---
Makefile | 1 +
t/helper/.gitignore | 1 +
t/helper/test-abbrev.c | 23 +++++++++++++++++++++++
t/perf/p0008-abbrev.sh | 12 ++++++++++++
4 files changed, 37 insertions(+)
create mode 100644 t/helper/test-abbrev.c
create mode 100755 t/perf/p0008-abbrev.sh
diff --git a/Makefile b/Makefile
index f2bb7f2f6..081ca05e8 100644
--- a/Makefile
+++ b/Makefile
@@ -633,6 +633,7 @@ X =
PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS))
+TEST_PROGRAMS_NEED_X += test-abbrev
TEST_PROGRAMS_NEED_X += test-chmtime
TEST_PROGRAMS_NEED_X += test-ctype
TEST_PROGRAMS_NEED_X += test-config
diff --git a/t/helper/.gitignore b/t/helper/.gitignore
index 721650256..80ce7d836 100644
--- a/t/helper/.gitignore
+++ b/t/helper/.gitignore
@@ -1,3 +1,4 @@
+/test-abbrev
/test-chmtime
/test-ctype
/test-config
diff --git a/t/helper/test-abbrev.c b/t/helper/test-abbrev.c
new file mode 100644
index 000000000..cb3551df9
--- /dev/null
+++ b/t/helper/test-abbrev.c
@@ -0,0 +1,23 @@
+#include "cache.h"
+
+int cmd_main(int ac, const char **av)
+{
+ setup_git_directory();
+
+ unsigned int hash_delt = 0x13579BDF;
+ unsigned int hash_base = 0x01020304;
+ struct object_id oid;
+
+ int i, count = 0;
+ int n = sizeof(struct object_id) / sizeof(int);
+ while (count++ < 100000) {
+ for (i = 0; i < n; i++)
+ ((unsigned int*)oid.hash)[i] = hash_base;
+
+ find_unique_abbrev(oid.hash, MINIMUM_ABBREV);
+
+ hash_base += hash_delt;
+ }
+
+ exit(0);
+}
diff --git a/t/perf/p0008-abbrev.sh b/t/perf/p0008-abbrev.sh
new file mode 100755
index 000000000..7c3fad807
--- /dev/null
+++ b/t/perf/p0008-abbrev.sh
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+test_description='Test object disambiguation through abbreviations'
+. ./perf-lib.sh
+
+test_perf_large_repo
+
+test_perf 'find_unique_abbrev()' '
+ test-abbrev
+'
+
+test_done
--
2.14.1.538.g56ec8fc98.dirty
next prev parent reply other threads:[~2017-09-15 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 16:57 [PATCH 0/3] Improve abbreviation disambiguation Derrick Stolee
2017-09-15 16:57 ` Derrick Stolee [this message]
2017-09-18 0:51 ` [PATCH 1/3] sha1_name: Create perf test for find_unique_abbrev() Junio C Hamano
2017-09-18 11:36 ` Derrick Stolee
2017-09-19 0:51 ` Junio C Hamano
2017-09-15 16:57 ` [PATCH 2/3] sha1_name: Unroll len loop in find_unique_abbrev_r Derrick Stolee
2017-09-15 16:57 ` [PATCH 3/3] sha1_name: Parse less while finding common prefix Derrick Stolee
2017-09-15 17:08 ` [PATCH 0/3] Improve abbreviation disambiguation Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915165750.198201-2-dstolee@microsoft.com \
--to=dstolee@microsoft.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kewillf@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).