From: Jeff King <peff@peff.net>
To: Sam Bobroff <sam.bobroff@au1.ibm.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] format-patch: use raw format for notes
Date: Wed, 13 Sep 2017 09:03:34 -0400 [thread overview]
Message-ID: <20170913130333.y4sgn5yjdebbvwzn@sigill.intra.peff.net> (raw)
In-Reply-To: <20170911042737.4h5b2jygdeu7cpmf@tungsten.ozlabs.ibm.com>
On Mon, Sep 11, 2017 at 02:27:38PM +1000, Sam Bobroff wrote:
> > - It is very much intended to allow The "(foo)" after the "Notes"
> > label to show which notes ref the note comes from, because there
> > can be more than one notes refs that annotate the same commit.
>
> Right, that makes perfect sense to me when it's being output locally.
>
> But the ref names are local to my git repo and there is no reaason why
> they should be meaningful or even known to the recipients of the patch
> email.
I can see how your notes names might not be of interest to others. But I
can also see how they _could_ be. For instance, if you kept test result
annotations in a notes ref, you would want to mark them as such.
The idea of the current output is that you'd put general text into
"refs/notes/commits" (which shows up only as "Notes:"). And if you are
putting notes in another ref, you have some reason to do so, which
implies that it's worth showing that they're not in the default ref.
I grant that there are reasons to do so which might not be worth showing
(e.g., you might be pushing and fetching refs, and keep some hierarchy).
But I don't think "are we emailing them" is a robust determiner of "are
they worth showing". So this probably needs to be a separate option,
rather than tied to the output format.
Or possibly there should be a naming convention (e.g., that everything
that ends in "/commits" doesn't have its name shown, which would allow
multiple hierarchies). It's hard to say without knowing the reason you
chose a non-default refname in the first place.
-Peff
prev parent reply other threads:[~2017-09-13 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 4:23 [PATCH] format-patch: use raw format for notes Sam Bobroff
2017-09-06 3:34 ` Junio C Hamano
2017-09-11 4:27 ` Sam Bobroff
2017-09-12 17:33 ` Stefan Beller
2017-09-13 0:38 ` Sam Bobroff
2017-09-13 13:03 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913130333.y4sgn5yjdebbvwzn@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sam.bobroff@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).