From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@grubix.eu>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/4] Test name-rev with small stack
Date: Thu, 7 Sep 2017 10:54:23 -0400 [thread overview]
Message-ID: <20170907145423.wz3iqxxz2yvxq5lm@sigill.intra.peff.net> (raw)
In-Reply-To: <cover.1504792601.git.git@grubix.eu>
On Thu, Sep 07, 2017 at 04:02:19PM +0200, Michael J Gruber wrote:
> name-rev segfaults for me in emacs.git with the typical 8102 stack size.
> The reason is the recursive walk that name-rev uses.
>
> This series adds a test to mark this as known failure, after some
> clean-ups.
These all look reasonable to me. The size of the test case in the final
one is presumably arbitrary and just copied from t7004. I don't know if
it's worth trying to shrink it. It could shorten a rather expensive
test. OTOH, if we shorten it too much then we might get a false pass
(e.g., if the algorithm remains recursive but has a smaller stack
footprint).
> Michael J Gruber (4):
> t7004: move limited stack prereq to test-lib
> t6120: test name-rev --all and --stdin
> t6120: clean up state after breaking repo
> t6120: test describe and name-rev with deep repos
Now comes the hard part: rewriting the C code. :)
-Peff
next prev parent reply other threads:[~2017-09-07 14:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 9:46 [PATCH] name-rev: change ULONG_MAX to TIME_MAX Michael J Gruber
2017-08-30 20:23 ` Johannes Schindelin
2017-09-06 3:35 ` Junio C Hamano
2017-09-06 11:59 ` Michael J Gruber
2017-09-06 13:35 ` Jeff King
2017-09-07 12:17 ` Michael J Gruber
2017-09-07 14:02 ` [PATCH 0/4] Test name-rev with small stack Michael J Gruber
2017-09-07 14:02 ` [PATCH 1/4] t7004: move limited stack prereq to test-lib Michael J Gruber
2017-09-07 14:02 ` [PATCH 2/4] t6120: test name-rev --all and --stdin Michael J Gruber
2017-09-07 14:02 ` [PATCH 3/4] t6120: clean up state after breaking repo Michael J Gruber
2017-09-07 14:02 ` [PATCH 4/4] t6120: test describe and name-rev with deep repos Michael J Gruber
2017-09-07 14:54 ` Jeff King [this message]
2017-09-08 12:33 ` [PATCH 0/4] Test name-rev with small stack Michael J Gruber
2017-09-11 18:08 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907145423.wz3iqxxz2yvxq5lm@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@grubix.eu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).