From: Jeff King <peff@peff.net>
To: "Paweł Marczewski" <pwmarcz@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Strange behavior of git rev-list
Date: Thu, 7 Sep 2017 06:11:26 -0400 [thread overview]
Message-ID: <20170907101126.u574pr7l5odff6zo@sigill.intra.peff.net> (raw)
In-Reply-To: <CACNsYJ8rRSf5gNtnPS05CnYCYGmoBymbgH7UumuOuBz1jp6RBA@mail.gmail.com>
On Thu, Sep 07, 2017 at 11:50:25AM +0200, Paweł Marczewski wrote:
> Thanks. Any plans to fix that? Or is there a way to turn off this heuristic?
I don't think there's a way to turn it off for `rev-list`. Merge-base
computations are more careful, so you could determine the correct
endpoints that way. But when you fed them to `rev-list`, it would hit
the same run of skewed commits.
We've discussed storing true generation numbers in the past, which would
make this optimization more robust, as well as allow us to speed up many
other traversals (e.g., the "tag --contains"). It's something I'd like
to revisit, but it's not at the top of the pile.
In the meantime, it would probably be possible to write a patch that
conditionally disables the optimization. But it would mean all of your
rev-lists run a _lot_ slower.
-Peff
next prev parent reply other threads:[~2017-09-07 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 9:20 Strange behavior of git rev-list Paweł Marczewski
2017-09-07 9:47 ` Jeff King
2017-09-07 9:50 ` Paweł Marczewski
2017-09-07 10:11 ` Jeff King [this message]
2017-09-07 19:24 ` Stefan Beller
2017-09-08 3:17 ` Jeff King
2017-09-08 3:37 ` Junio C Hamano
2017-09-08 3:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907101126.u574pr7l5odff6zo@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pwmarcz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).