* [PATCH] submodule.sh: remove unused variable
@ 2017-08-16 22:50 Stefan Beller
2017-08-16 22:59 ` Jonathan Nieder
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Beller @ 2017-08-16 22:50 UTC (permalink / raw)
To: jrnieder; +Cc: git, Stefan Beller
This could have been part of 48308681b0 (git submodule update: have a
dedicated helper for cloning, 2016-02-29).
Signed-off-by: Stefan Beller <sbeller@google.com>
---
git-submodule.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index e131760eec..9dcec7b356 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -611,7 +611,6 @@ cmd_update()
die_if_unmatched "$mode" "$sha1"
name=$(git submodule--helper name "$sm_path") || exit
- url=$(git config submodule."$name".url)
if ! test -z "$update"
then
update_module=$update
--
2.14.0.rc0.3.g6c2e499285
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] submodule.sh: remove unused variable
2017-08-16 22:50 [PATCH] submodule.sh: remove unused variable Stefan Beller
@ 2017-08-16 22:59 ` Jonathan Nieder
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2017-08-16 22:59 UTC (permalink / raw)
To: Stefan Beller; +Cc: git
Stefan Beller wrote:
> This could have been part of 48308681b0 (git submodule update: have a
> dedicated helper for cloning, 2016-02-29).
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> git-submodule.sh | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks for cleaning up.
> diff --git a/git-submodule.sh b/git-submodule.sh
> index e131760eec..9dcec7b356 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -611,7 +611,6 @@ cmd_update()
> die_if_unmatched "$mode" "$sha1"
>
> name=$(git submodule--helper name "$sm_path") || exit
> - url=$(git config submodule."$name".url)
> if ! test -z "$update"
> then
> update_module=$update
> --
> 2.14.0.rc0.3.g6c2e499285
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-16 22:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-16 22:50 [PATCH] submodule.sh: remove unused variable Stefan Beller
2017-08-16 22:59 ` Jonathan Nieder
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).